Issue 1318003004: Revert of DevTools: [security] open certificate viewer from devtools security overview (blink)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318003004: Revert of DevTools: [security] open certificate viewer from devtools security overview (blink) (Closed)

Created:
5 years, 3 months ago by caseq

Modified:
5 years, 3 months ago

Reviewers:
lgarron, dgozman, pfeldman, estark

CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of DevTools: [security] open certificate viewer from devtools security overview (blink) (patchset #3 id:40001 of https://codereview.chromium.org/1327593003/ ) Reason for revert: Broke the front_end compilation. Original issue's description: > DevTools: [security] open certificate viewer from devtools security overview (blink) > > BUG=506468 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201676 TBR=lgarron@chromium.org,dgozman@chromium.org,estark@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506468 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201685

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -20 lines)			Patch
M	Source/devtools/front_end/security/SecurityPanel.js	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	Source/devtools/front_end/security/mainView.css	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

caseq

Created Revert of DevTools: [security] open certificate viewer from devtools security overview (blink)

5 years, 3 months ago (2015-09-03 00:29:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318003004/1

5 years, 3 months ago (2015-09-03 00:30:01 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-03 00:30:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201685

Expand Messages | Collapse Messages