Adding metrics for notification clicks and dismissals

chrome/browser/resources/google_now/background.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview The event page for Google Now for Chrome implementation.
  * The Google Now event page gets Google Now cards from the server and shows
  * them as Chrome notifications.
@@ skipping 420 matching lines @@
 
 /**
  * Callback for chrome.notifications.onClosed event.
  * @param {string} notificationId Unique identifier of the notification.
  * @param {boolean} byUser Whether the notification was closed by the user.
  */
 function onNotificationClosed(notificationId, byUser) {
   if (!byUser)
     return;
 
+  chrome.metricsPrivate.recordUserAction('GoogleNow.Dismissed');
+

[rgustafson, 2013/03/29 20:20:00]

unnecessary new line

[vadimt, 2013/03/29 20:22:44]

Yeah, I thought about this too. Given that it goes before a large block, the
newline seems appropriate.
However, let me know if you feel strong about removing it.

   tasks.add(DISMISS_CARD_TASK_NAME, function(callback) {
     // Schedule retrying dismissing until all dismissals go through.
     // TODO(vadimt): Implement exponential backoff and unify it with getting
     // cards.
     var alarmInfo = {
       delayInMinutes: RETRY_DISMISS_PERIOD_SECONDS / 60,
       periodInMinutes: RETRY_DISMISS_PERIOD_SECONDS / 60
     };
 
     chrome.alarms.create(RETRY_DISMISS_ALARM_NAME, alarmInfo);
@@ skipping 58 matching lines @@
 
 chrome.alarms.onAlarm.addListener(function(alarm) {
   if (alarm.name == UPDATE_NOTIFICATIONS_ALARM_NAME)
     updateNotificationsCards();
   else if (alarm.name == RETRY_DISMISS_ALARM_NAME)
     retryPendingDismissals();
 });
 
 chrome.notifications.onClicked.addListener(
     function(notificationId) {
+      chrome.metricsPrivate.recordUserAction('GoogleNow.MessageClicked');
       onNotificationClicked(notificationId, function(actionUrls) {
         return actionUrls.messageUrl;
       });
     });
 
 chrome.notifications.onButtonClicked.addListener(
     function(notificationId, buttonIndex) {
+      chrome.metricsPrivate.recordUserAction(
+          'GoogleNow.ButtonClicked' + buttonIndex);
       onNotificationClicked(notificationId, function(actionUrls) {
         if (!Array.isArray(actionUrls.buttonUrls))
           return undefined;
 
         return actionUrls.buttonUrls[buttonIndex];
       });
     });
 
 chrome.notifications.onClosed.addListener(onNotificationClosed);