Adding metrics for notification clicks and dismissals

chrome/browser/resources/google_now/metrics.js

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Utility methods for accessing chrome.metricsPrivate API.
  *
  * To be included as a first script in main.html
  */
 
+// This file was adapted from

[rgustafson, 2013/03/28 21:49:56]

What other metrics will you track with this? If you're just using
recordUserAction, this seems unnecessarily large.

[vadimt, 2013/03/28 22:05:05]

I also plan to record errors (may be, using histograms).
The file has a TODO item to remove dead code before release.

[rgustafson, 2013/03/29 02:17:55]

There's absolutely no benefit to having this file right now, just more
complexity to accomplish what could already be done in one line. I'd much prefer
that you add this when you need it (or add code now that does make this
necessary and lower the number of reviews for owners in the other various
directories).

[skare_, 2013/03/29 18:08:35]

agree - duplicating a sibling file seems error-prone, confusing for people who
search for that API later, and might increase the size of the binary
unnecessarily. You might not even need a wrapper around the API, similar to how
Notifications Galore has one for notifications and you just call the API direct.

[vadimt, 2013/03/29 20:15:28]

Done.

[vadimt, 2013/03/29 20:15:28]

Done.

+// chrome/browser/resources/file_manager/js/metrics.js.
+// TODO(vadimt): Remove unused code.

[skare_, 2013/03/28 21:24:51]

possible to unify between the two extensions?

[vadimt, 2013/03/28 21:36:50]

Ideas?
Copy from file_manager as a custom build step?

[skare_, 2013/03/29 18:08:35]

something like that, but only when you really need it. Or just call the APIs
directly.

[vadimt, 2013/03/29 20:15:28]

Done.

+
 var metrics = {};
 
 /**
  * A map from interval name to interval start timestamp.
  */
 metrics.intervals = {};
 
 /**
  * Start the named time interval.
  * Should be followed by a call to recordInterval with the same name.
  *
  * @param {string} name Unique interval name.
  */
 metrics.startInterval = function(name) {
   metrics.intervals[name] = Date.now();
 };
 
 metrics.startInterval('Load.Total');
 metrics.startInterval('Load.Script');
 
 /**
  * Convert a short metric name to the full format.
  *
  * @param {string} name Short metric name.
  * @return {string} Full metric name.
  * @private
  */
 metrics.convertName_ = function(name) {
-  return 'FileBrowser.' + name;
+  return 'GoogleNow.' + name;
 };
 
 /**
- * Wrapper method for calling chrome.fileBrowserPrivate safely.
+ * Wrapper method for calling chrome.metricsPrivate safely.
  * @param {string} name Method name.
  * @param {Array.<Object>} args Arguments.
  * @private
  */
 metrics.call_ = function(name, args) {
   if (!chrome.metricsPrivate)
     return;  // Mock object not loaded yet, ignore.
 
   try {
     chrome.metricsPrivate[name].apply(chrome.metricsPrivate, args);
@@ skipping 71 matching lines @@
     'min': 1,
     'max': boundaryValue,
     'buckets': boundaryValue + 1
   };
   metrics.call_('recordValue', [metricDescr, index]);
   if (metrics.log) {
     console.log('chrome.metricsPrivate.recordValue',
         [metricDescr.metricName, index, value]);
   }
 };