Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1317973006:
Roll WebRTC 9867:9890, Libjingle 9867:9885 (Closed)
|
Created:
5 years, 3 months ago by hbos_chromium Modified:
5 years, 3 months ago CC:
chromium-reviews, chromoting-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll WebRTC 9867:9890, Libjingle 9867:9885
WebRTC 9867:9890
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/22fd889..e3f2eba
Libjingle 9867:9885
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/ca717fa..531209a
Additional Chromium changes:
Updated MockTransportChannel to compile with the latest webrtc changes.
TBR=guidou@chromium.org, garykac@chromium.org, tommi@chromium.org
BUG=
Committed: https://crrev.com/d8d6b53f54007c9b4eae42fdd5019d3cff60c2ce
Cr-Commit-Position: refs/heads/master@{#347695}
Patch Set 1 #
Messages
Total messages: 29 (14 generated)
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973006/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973006/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
hbos@chromium.org changed reviewers: + guidou@chromium.org, tommi@webrtc.org
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973006/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
hbos@chromium.org changed reviewers: + garykac@chromium.org
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973006/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
hbos@chromium.org changed reviewers: + tommi@chromium.org - tommi@webrtc.org
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973006/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/09/08 12:27:41, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Sorry for the spam, I apparently don't know how CQ/TBR works. Want to land this ASAP to fix WebRTC-in-Chrome trybots not compiling, thought I could TBR it.
The CQ bit was checked by tommi@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d8d6b53f54007c9b4eae42fdd5019d3cff60c2ce Cr-Commit-Position: refs/heads/master@{#347695} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
