Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1317973003: Devtools UI: Fix recording shortcut on Mac to use Cmd not Ctrl (Closed)

Created:
5 years, 3 months ago by samli
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools UI: Fix recording shortcut on Mac to use Cmd not Ctrl BUG=526568 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M Source/devtools/front_end/profiler/module.json View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
samli
5 years, 3 months ago (2015-08-31 18:12:01 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-08-31 18:24:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973003/1
5 years, 3 months ago (2015-08-31 20:45:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/126773)
5 years, 3 months ago (2015-08-31 21:05:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317973003/1
5 years, 3 months ago (2015-08-31 21:36:39 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 22:49:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201506

Powered by Google App Engine
This is Rietveld 408576698