Issue 1317933004: Fix declspec and GNU attribute order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1317933004: Fix declspec and GNU attribute order (Closed)

Created:
5 years, 3 months ago by Ken Rockot(use gerrit already)

Modified:
5 years, 3 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix declspec and GNU attribute order Clang fails at parsing clsas __declspec(dllexport) __attribute__((lockable)) Mutex {}; but it can parse when attribute and declspec are swapped. BUG=82385 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/edad3cdc473a9afc29e3b73ccc926f24e91f4b10

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/edk/system/mutex.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

5 years, 3 months ago (2015-08-27 22:31:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
edad3cdc473a9afc29e3b73ccc926f24e91f4b10 (presubmit successful).

Expand Messages | Collapse Messages