Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: Source/core/html/parser/HTMLDocumentParser.h

Issue 131793003: Update remaining HTML classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/ime/InputMethodContext.h ('k') | Source/core/html/parser/TextDocumentParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/HTMLDocumentParser.h
diff --git a/Source/core/html/parser/HTMLDocumentParser.h b/Source/core/html/parser/HTMLDocumentParser.h
index 40779561ad36e7acbe3004ab4bcaa7410e8ba133..af0feead60325315862ec6f884bec14f6ae36a09 100644
--- a/Source/core/html/parser/HTMLDocumentParser.h
+++ b/Source/core/html/parser/HTMLDocumentParser.h
@@ -80,11 +80,11 @@ public:
HTMLTokenizer* tokenizer() const { return m_tokenizer.get(); }
- virtual TextPosition textPosition() const;
- virtual OrdinalNumber lineNumber() const;
+ virtual TextPosition textPosition() const OVERRIDE FINAL;
eseidel 2014/01/10 19:08:23 It's really sad this whole class isn't final. :(
Inactive 2014/01/10 19:11:45 Yes.. Sadly, TextDocumentParser derives from this
+ virtual OrdinalNumber lineNumber() const OVERRIDE FINAL;
- virtual void suspendScheduledTasks();
- virtual void resumeScheduledTasks();
+ virtual void suspendScheduledTasks() OVERRIDE FINAL;
+ virtual void resumeScheduledTasks() OVERRIDE FINAL;
struct ParsedChunk {
OwnPtr<CompactHTMLTokenStream> tokens;
@@ -100,9 +100,9 @@ public:
UseCounter* useCounter() { return UseCounter::getFrom(contextForParsingSession()); }
protected:
- virtual void insert(const SegmentedString&) OVERRIDE;
+ virtual void insert(const SegmentedString&) OVERRIDE FINAL;
virtual void append(PassRefPtr<StringImpl>) OVERRIDE;
- virtual void finish() OVERRIDE;
+ virtual void finish() OVERRIDE FINAL;
HTMLDocumentParser(HTMLDocument*, bool reportErrors);
HTMLDocumentParser(DocumentFragment*, Element* contextElement, ParserContentPolicy);
@@ -118,25 +118,25 @@ private:
}
// DocumentParser
- virtual void pinToMainThread() OVERRIDE;
- virtual void detach() OVERRIDE;
- virtual bool hasInsertionPoint() OVERRIDE;
- virtual bool processingData() const OVERRIDE;
- virtual void prepareToStopParsing() OVERRIDE;
- virtual void stopParsing() OVERRIDE;
- virtual bool isWaitingForScripts() const OVERRIDE;
- virtual bool isExecutingScript() const OVERRIDE;
- virtual void executeScriptsWaitingForResources() OVERRIDE;
+ virtual void pinToMainThread() OVERRIDE FINAL;
+ virtual void detach() OVERRIDE FINAL;
+ virtual bool hasInsertionPoint() OVERRIDE FINAL;
+ virtual bool processingData() const OVERRIDE FINAL;
+ virtual void prepareToStopParsing() OVERRIDE FINAL;
+ virtual void stopParsing() OVERRIDE FINAL;
+ virtual bool isWaitingForScripts() const OVERRIDE FINAL;
+ virtual bool isExecutingScript() const OVERRIDE FINAL;
+ virtual void executeScriptsWaitingForResources() OVERRIDE FINAL;
// HTMLScriptRunnerHost
- virtual void watchForLoad(Resource*) OVERRIDE;
- virtual void stopWatchingForLoad(Resource*) OVERRIDE;
- virtual HTMLInputStream& inputStream() { return m_input; }
- virtual bool hasPreloadScanner() const { return m_preloadScanner.get() && !shouldUseThreading(); }
- virtual void appendCurrentInputStreamToPreloadScannerAndScan() OVERRIDE;
+ virtual void watchForLoad(Resource*) OVERRIDE FINAL;
+ virtual void stopWatchingForLoad(Resource*) OVERRIDE FINAL;
+ virtual HTMLInputStream& inputStream() OVERRIDE FINAL { return m_input; }
+ virtual bool hasPreloadScanner() const OVERRIDE FINAL { return m_preloadScanner.get() && !shouldUseThreading(); }
+ virtual void appendCurrentInputStreamToPreloadScannerAndScan() OVERRIDE FINAL;
// ResourceClient
- virtual void notifyFinished(Resource*);
+ virtual void notifyFinished(Resource*) OVERRIDE FINAL;
void startBackgroundParser();
void stopBackgroundParser();
« no previous file with comments | « Source/core/html/ime/InputMethodContext.h ('k') | Source/core/html/parser/TextDocumentParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698