Update remaining HTML classes to use OVERRIDE / FINAL when needed

Update remaining HTML classes to use OVERRIDE / FINAL when needed

Update remaining HTML classes to use OVERRIDE / FINAL when needed. Those are
useful for error checking or performance when the compiler supports it.

R=esprehn, abarth
BUG=333316
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164920

[eseidel, 2014-01-10 19:08:22]

lgtm

You must be using a tool to do this, no?

https://codereview.chromium.org/131793003/diff/1/Source/core/html/parser/HTML...
File Source/core/html/parser/HTMLDocumentParser.h (right):

https://codereview.chromium.org/131793003/diff/1/Source/core/html/parser/HTML...
Source/core/html/parser/HTMLDocumentParser.h:83: virtual TextPosition
textPosition() const OVERRIDE FINAL;
It's really sad this whole class isn't final. :(

[Inactive, 2014-01-10 19:11:44]

My IDE (Qt Creator) makes this relatively easy (Type hierarchy, Show Usages,
...) :)

https://codereview.chromium.org/131793003/diff/1/Source/core/html/parser/HTML...
File Source/core/html/parser/HTMLDocumentParser.h (right):

https://codereview.chromium.org/131793003/diff/1/Source/core/html/parser/HTML...
Source/core/html/parser/HTMLDocumentParser.h:83: virtual TextPosition
textPosition() const OVERRIDE FINAL;
On 2014/01/10 19:08:23, eseidel wrote:
> It's really sad this whole class isn't final. :(

Yes.. Sadly, TextDocumentParser derives from this class.

[commit-bot: I haz the power, 2014-01-10 20:06:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/131793003/1

[commit-bot: I haz the power, 2014-01-10 20:07:30]

Failed to apply patch for Source/core/html/parser/TextDocumentParser.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/parser/TextDocumentParser.h
  Hunk #2 FAILED at 41.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/html/parser/TextDocumentParser.h.rej

Patch:       Source/core/html/parser/TextDocumentParser.h
Index: Source/core/html/parser/TextDocumentParser.h
diff --git a/Source/core/html/parser/TextDocumentParser.h
b/Source/core/html/parser/TextDocumentParser.h
index
6b5bb9e6a4c7bcb10b1c645ed00acf1e61fde76b..255eccfdba6af3b49f4aed64ea4f2f6dfb8a8b79
100644
--- a/Source/core/html/parser/TextDocumentParser.h
+++ b/Source/core/html/parser/TextDocumentParser.h
@@ -30,7 +30,7 @@
 
 namespace WebCore {
 
-class TextDocumentParser : public HTMLDocumentParser {
+class TextDocumentParser FINAL : public HTMLDocumentParser {
 public:
     static PassRefPtr<TextDocumentParser> create(HTMLDocument* document)
     {
@@ -41,7 +41,7 @@ public:
 private:
     explicit TextDocumentParser(HTMLDocument*);
 
-    virtual void append(PassRefPtr<StringImpl>);
+    virtual void append(PassRefPtr<StringImpl>) OVERRIDE;
     void insertFakePreElement();
 
     bool m_haveInsertedFakePreElement;

[commit-bot: I haz the power, 2014-01-10 20:23:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/131793003/140001

[commit-bot: I haz the power, 2014-01-10 21:17:29]

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-10 22:06:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/131793003/140001

[commit-bot: I haz the power, 2014-01-10 22:59:37]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-10 23:56:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/131793003/140001

[commit-bot: I haz the power, 2014-01-11 01:45:46]

Change committed as 164920