Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1317833005: PlzNavigate: Expose blink to content enum type converters. (Closed)

Created:
5 years, 3 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Expose blink to content enum type converters. This is a spin-off of https://codereview.chromium.org/1294243004/ This exposes the helper functions converting enum types from a blink type to its corresponding content type. BUG=440463 Committed: https://crrev.com/f961204e71ecd50dbed4bb1eb8e45ee62ffaf69c Cr-Commit-Position: refs/heads/master@{#348772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -133 lines) Patch
M content/child/web_url_loader_impl.cc View 2 chunks +10 lines, -133 lines 0 comments Download
M content/child/web_url_request_util.h View 2 chunks +16 lines, -0 lines 0 comments Download
M content/child/web_url_request_util.cc View 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Fabrice (no longer in Chrome)
nasko: PTAL others: FYI This is a simple spin-off of https://codereview.chromium.org/1294243004/ I am preparing another ...
5 years, 3 months ago (2015-09-07 16:59:47 UTC) #2
clamy
Thanks! Lgtm
5 years, 3 months ago (2015-09-14 19:52:08 UTC) #3
nasko
LGTM
5 years, 3 months ago (2015-09-14 21:08:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317833005/1
5 years, 3 months ago (2015-09-14 21:29:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/40504)
5 years, 3 months ago (2015-09-14 23:06:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317833005/1
5 years, 3 months ago (2015-09-14 23:08:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 23:50:24 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f961204e71ecd50dbed4bb1eb8e45ee62ffaf69c Cr-Commit-Position: refs/heads/master@{#348772}
5 years, 3 months ago (2015-09-14 23:51:11 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f961204e71ecd50dbed4bb1eb8e45ee62ffaf69c
Cr-Commit-Position: refs/heads/master@{#348772}

Powered by Google App Engine
This is Rietveld 408576698