Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Unified Diff: content/public/browser/resource_dispatcher_host_delegate.h

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary DCHECK Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/resource_dispatcher_host_delegate.h
diff --git a/content/public/browser/resource_dispatcher_host_delegate.h b/content/public/browser/resource_dispatcher_host_delegate.h
index 0d0eebc49163eb7edaa05126ba7d8f362a1cbb2a..598cffbe099eac74157bb64c21ddbd23ff5923c8 100644
--- a/content/public/browser/resource_dispatcher_host_delegate.h
+++ b/content/public/browser/resource_dispatcher_host_delegate.h
@@ -84,9 +84,12 @@ class CONTENT_EXPORT ResourceDispatcherHostDelegate {
// Launches the url for the given tab. Returns true if an attempt to handle
// the url was made, e.g. by launching an app. Note that this does not
// guarantee that the app successfully handled it.
+ // Some external protocol handlers only run in the context of a user gesture,
+ // so initiated_by_user_gesture should be passed accordingly.
virtual bool HandleExternalProtocol(const GURL& url,
int child_id,
- int route_id);
+ int route_id,
+ bool initiated_by_user_gesture);
// Returns true if we should force the given resource to be downloaded.
// Otherwise, the content layer decides.
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/public/browser/resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698