chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h - Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unnecessary DCHECK Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

index 8bcf06ad2a1d7be4c360b7823eddbabbcd2d1a79..b154b5b0f6e99bfb5e1bf8ffb4e9df0b1a34d7f2 100644

--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

@@ -65,7 +65,8 @@ class ChromeResourceDispatcherHostDelegate

net::AuthChallengeInfo* auth_info, net::URLRequest* request) OVERRIDE;

virtual bool HandleExternalProtocol(const GURL& url,

int child_id,

- int route_id) OVERRIDE;

+ int route_id,

+ bool initiated_by_user_gesture) OVERRIDE;

virtual bool ShouldForceDownloadResource(

const GURL& url, const std::string& mime_type) OVERRIDE;

virtual bool ShouldInterceptResourceAsStream(