Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/autocomplete/autocomplete_input.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary DCHECK Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_input.cc
diff --git a/chrome/browser/autocomplete/autocomplete_input.cc b/chrome/browser/autocomplete/autocomplete_input.cc
index ea4285172a6a3c21fd963991f877554d079d22ff..198c09226366597b3ebfe23915dad112f32055c2 100644
--- a/chrome/browser/autocomplete/autocomplete_input.cc
+++ b/chrome/browser/autocomplete/autocomplete_input.cc
@@ -198,9 +198,12 @@ AutocompleteInput::Type AutocompleteInput::Parse(
// handlable schemes (e.g. "javascript") may be treated as "blocked" by the
// external protocol handler because we don't want pages to open them, but
// users still can.
+ // Note that the protocol handler needs to be informed that omnibox input
+ // should always be considered "user gesture-triggered", lest it always
+ // return BLOCK.
ExternalProtocolHandler::BlockState block_state =
ExternalProtocolHandler::GetBlockState(
- base::UTF16ToUTF8(parsed_scheme));
+ base::UTF16ToUTF8(parsed_scheme), true);
switch (block_state) {
case ExternalProtocolHandler::DONT_BLOCK:
return return_value_for_non_http_url;

Powered by Google App Engine
This is Rietveld 408576698