extensions/browser/extension_function_dispatcher.cc - Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function_dispatcher.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: joi and pkasting comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « content/public/browser/resource_dispatcher_host_delegate.cc ('k') | extensions/browser/extensions_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function_dispatcher.cc

diff --git a/extensions/browser/extension_function_dispatcher.cc b/extensions/browser/extension_function_dispatcher.cc

index 3e29582c0455cfcfde1ede00b1e2dd6508469172..8a06968c20f32d0fa62510a73f2a6516692f0a43 100644

--- a/extensions/browser/extension_function_dispatcher.cc

+++ b/extensions/browser/extension_function_dispatcher.cc

@@ -382,8 +382,6 @@ void ExtensionFunctionDispatcher::DispatchWithCallbackInternal(

if (violation_error.empty()) {

scoped_ptr<base::ListValue> args(params.arguments.DeepCopy());

- // See crbug.com/39178.

- ExtensionsBrowserClient::Get()->PermitExternalProtocolHandler();

NotifyApiFunctionCalled(

extension->id(), params.name, args.Pass(), browser_context_);

function->Run();