chrome/browser/ui/tab_helpers.cc - Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: joi and pkasting comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('K') | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/chrome_browser.gypi » ('j') | content/browser/loader/resource_dispatcher_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index fc586cf344ecc69f7a363a54517237d9cbaa656f..3c811bb7128819aaf8fdb3e4666125235285a9f0 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -40,7 +40,6 @@

#else

#include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"

#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"

-#include "chrome/browser/external_protocol/external_protocol_observer.h"

#include "chrome/browser/net/predictor_tab_helper.h"

#include "chrome/browser/network_time/navigation_time_helper.h"

#include "chrome/browser/plugins/plugin_observer.h"

@@ -155,7 +154,6 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(

web_contents);

extensions::WebNavigationTabObserver::CreateForWebContents(web_contents);

- ExternalProtocolObserver::CreateForWebContents(web_contents);

HungPluginTabHelper::CreateForWebContents(web_contents);

ManagePasswordsBubbleUIController::CreateForWebContents(web_contents);

NavigationTimeHelper::CreateForWebContents(web_contents);