chrome/browser/extensions/extension_function_dispatcher.cc - Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_dispatcher.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix build Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_tab_permission_granter.cc ('k') | chrome/browser/external_protocol/external_protocol_handler.h » ('j') | chrome/browser/external_protocol/external_protocol_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_function_dispatcher.cc

diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc

index 944763f5bbe56dd05eb98cbb22f1081b5909c641..ce266a4dc9fe902c151edc398b3f48d5476b4024 100644

--- a/chrome/browser/extensions/extension_function_dispatcher.cc

+++ b/chrome/browser/extensions/extension_function_dispatcher.cc

@@ -389,9 +389,6 @@ void ExtensionFunctionDispatcher::DispatchWithCallbackInternal(

base::TimeTicks::Now());

if (violation_error.empty()) {

scoped_ptr<base::ListValue> args(params.arguments.DeepCopy());

- // See crbug.com/39178.

- ExternalProtocolHandler::PermitLaunchUrl();

NotifyApiFunctionCalled(

extension->id(), params.name, args.Pass(), browser_context_);

function->Run();