Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: chrome/browser/ui/tab_helpers.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary DCHECK Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_helpers.h" 5 #include "chrome/browser/ui/tab_helpers.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 9 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
10 #include "chrome/browser/extensions/tab_helper.h" 10 #include "chrome/browser/extensions/tab_helper.h"
(...skipping 22 matching lines...) Expand all
33 #include "content/public/browser/web_contents.h" 33 #include "content/public/browser/web_contents.h"
34 #include "extensions/browser/view_type_utils.h" 34 #include "extensions/browser/view_type_utils.h"
35 35
36 #if defined(OS_ANDROID) 36 #if defined(OS_ANDROID)
37 #include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h" 37 #include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"
38 #include "chrome/browser/ui/android/context_menu_helper.h" 38 #include "chrome/browser/ui/android/context_menu_helper.h"
39 #include "chrome/browser/ui/android/window_android_helper.h" 39 #include "chrome/browser/ui/android/window_android_helper.h"
40 #else 40 #else
41 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h" 41 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"
42 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 42 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
43 #include "chrome/browser/external_protocol/external_protocol_observer.h"
44 #include "chrome/browser/net/predictor_tab_helper.h" 43 #include "chrome/browser/net/predictor_tab_helper.h"
45 #include "chrome/browser/network_time/navigation_time_helper.h" 44 #include "chrome/browser/network_time/navigation_time_helper.h"
46 #include "chrome/browser/plugins/plugin_observer.h" 45 #include "chrome/browser/plugins/plugin_observer.h"
47 #include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h" 46 #include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"
48 #include "chrome/browser/thumbnails/thumbnail_tab_helper.h" 47 #include "chrome/browser/thumbnails/thumbnail_tab_helper.h"
49 #include "chrome/browser/ui/hung_plugin_tab_helper.h" 48 #include "chrome/browser/ui/hung_plugin_tab_helper.h"
50 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h" 49 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
51 #include "chrome/browser/ui/pdf/pdf_tab_helper.h" 50 #include "chrome/browser/ui/pdf/pdf_tab_helper.h"
52 #include "chrome/browser/ui/sad_tab_helper.h" 51 #include "chrome/browser/ui/sad_tab_helper.h"
53 #include "chrome/browser/ui/search/search_tab_helper.h" 52 #include "chrome/browser/ui/search/search_tab_helper.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 144
146 #if defined(OS_ANDROID) 145 #if defined(OS_ANDROID)
147 ContextMenuHelper::CreateForWebContents(web_contents); 146 ContextMenuHelper::CreateForWebContents(web_contents);
148 SingleTabModeTabHelper::CreateForWebContents(web_contents); 147 SingleTabModeTabHelper::CreateForWebContents(web_contents);
149 WindowAndroidHelper::CreateForWebContents(web_contents); 148 WindowAndroidHelper::CreateForWebContents(web_contents);
150 #else 149 #else
151 chrome_browser_net::PredictorTabHelper::CreateForWebContents(web_contents); 150 chrome_browser_net::PredictorTabHelper::CreateForWebContents(web_contents);
152 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents( 151 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
153 web_contents); 152 web_contents);
154 extensions::WebNavigationTabObserver::CreateForWebContents(web_contents); 153 extensions::WebNavigationTabObserver::CreateForWebContents(web_contents);
155 ExternalProtocolObserver::CreateForWebContents(web_contents);
156 HungPluginTabHelper::CreateForWebContents(web_contents); 154 HungPluginTabHelper::CreateForWebContents(web_contents);
157 ManagePasswordsBubbleUIController::CreateForWebContents(web_contents); 155 ManagePasswordsBubbleUIController::CreateForWebContents(web_contents);
158 NavigationTimeHelper::CreateForWebContents(web_contents); 156 NavigationTimeHelper::CreateForWebContents(web_contents);
159 PDFTabHelper::CreateForWebContents(web_contents); 157 PDFTabHelper::CreateForWebContents(web_contents);
160 PermissionBubbleManager::CreateForWebContents(web_contents); 158 PermissionBubbleManager::CreateForWebContents(web_contents);
161 PluginObserver::CreateForWebContents(web_contents); 159 PluginObserver::CreateForWebContents(web_contents);
162 SadTabHelper::CreateForWebContents(web_contents); 160 SadTabHelper::CreateForWebContents(web_contents);
163 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents); 161 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);
164 SearchEngineTabHelper::CreateForWebContents(web_contents); 162 SearchEngineTabHelper::CreateForWebContents(web_contents);
165 SearchTabHelper::CreateForWebContents(web_contents); 163 SearchTabHelper::CreateForWebContents(web_contents);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 if (OneClickSigninHelper::CanOffer(web_contents, 203 if (OneClickSigninHelper::CanOffer(web_contents,
206 OneClickSigninHelper::CAN_OFFER_FOR_ALL, 204 OneClickSigninHelper::CAN_OFFER_FOR_ALL,
207 std::string(), 205 std::string(),
208 NULL)) { 206 NULL)) {
209 OneClickSigninHelper::CreateForWebContentsWithPasswordManager( 207 OneClickSigninHelper::CreateForWebContentsWithPasswordManager(
210 web_contents, 208 web_contents,
211 ChromePasswordManagerClient::GetManagerFromWebContents(web_contents)); 209 ChromePasswordManagerClient::GetManagerFromWebContents(web_contents));
212 } 210 }
213 #endif 211 #endif
214 } 212 }
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698