Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Side by Side Diff: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary DCHECK Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_dele gate.h" 5 #include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_dele gate.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "android_webview/browser/aw_contents_io_thread_client.h" 9 #include "android_webview/browser/aw_contents_io_thread_client.h"
10 #include "android_webview/browser/aw_login_delegate.h" 10 #include "android_webview/browser/aw_login_delegate.h"
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 } 291 }
292 } 292 }
293 293
294 content::ResourceDispatcherHostLoginDelegate* 294 content::ResourceDispatcherHostLoginDelegate*
295 AwResourceDispatcherHostDelegate::CreateLoginDelegate( 295 AwResourceDispatcherHostDelegate::CreateLoginDelegate(
296 net::AuthChallengeInfo* auth_info, 296 net::AuthChallengeInfo* auth_info,
297 net::URLRequest* request) { 297 net::URLRequest* request) {
298 return new AwLoginDelegate(auth_info, request); 298 return new AwLoginDelegate(auth_info, request);
299 } 299 }
300 300
301 bool AwResourceDispatcherHostDelegate::HandleExternalProtocol(const GURL& url, 301 bool AwResourceDispatcherHostDelegate::HandleExternalProtocol(
302 int child_id, 302 const GURL& url,
303 int route_id) { 303 int child_id,
304 int route_id,
305 bool initiated_by_user_gesture) {
304 // The AwURLRequestJobFactory implementation should ensure this method never 306 // The AwURLRequestJobFactory implementation should ensure this method never
305 // gets called. 307 // gets called.
306 NOTREACHED(); 308 NOTREACHED();
307 return false; 309 return false;
308 } 310 }
309 311
310 void AwResourceDispatcherHostDelegate::OnResponseStarted( 312 void AwResourceDispatcherHostDelegate::OnResponseStarted(
311 net::URLRequest* request, 313 net::URLRequest* request,
312 content::ResourceContext* resource_context, 314 content::ResourceContext* resource_context,
313 content::ResourceResponse* response, 315 content::ResourceResponse* response,
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 net::HttpRequestHeaders headers; 421 net::HttpRequestHeaders headers;
420 headers.AddHeadersFromString(extra_headers); 422 headers.AddHeadersFromString(extra_headers);
421 for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext(); ) { 423 for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext(); ) {
422 request->SetExtraRequestHeaderByName(it.name(), it.value(), false); 424 request->SetExtraRequestHeaderByName(it.name(), it.value(), false);
423 } 425 }
424 } 426 }
425 } 427 }
426 } 428 }
427 429
428 } // namespace android_webview 430 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698