Fix the handling of user gestures for external protocol handler dialogs.

content/public/browser/resource_dispatcher_host_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_DISPATCHER_HOST_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_RESOURCE_DISPATCHER_HOST_DELEGATE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 68 matching lines @@
   // Creates a ResourceDispatcherHostLoginDelegate that asks the user for a
   // username and password.
   virtual ResourceDispatcherHostLoginDelegate* CreateLoginDelegate(
       net::AuthChallengeInfo* auth_info, net::URLRequest* request);
 
   // Launches the url for the given tab. Returns true if an attempt to handle
   // the url was made, e.g. by launching an app. Note that this does not
   // guarantee that the app successfully handled it.
   virtual bool HandleExternalProtocol(const GURL& url,
                                       int child_id,
-                                      int route_id);
+                                      int route_id,
+                                      bool user_gesture);

[Jói, 2014/03/28 22:19:40]

A boolean flag with this name does not make it 100% clear what this does. I
think this needs a better name (e.g. starting with is_ or initiated_by_ or some
such) and some documentation.

[meacer, 2014/03/28 23:13:57]

Done.

 
   // Returns true if we should force the given resource to be downloaded.
   // Otherwise, the content layer decides.
   virtual bool ShouldForceDownloadResource(
       const GURL& url, const std::string& mime_type);
 
   // Returns true and sets |origin| and |target_id| if a Stream should be
   // created for the resource.
   // If true is returned, a new Stream will be created and OnStreamCreated()
   // will be called with
@@ skipping 38 matching lines @@
   virtual void RequestComplete(net::URLRequest* url_request);
 
  protected:
   ResourceDispatcherHostDelegate();
   virtual ~ResourceDispatcherHostDelegate();
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RESOURCE_DISPATCHER_HOST_DELEGATE_H_