Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix build Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <deque> 5 #include <deque>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 947 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 // ExternalProtocolHandler::Delegate implementation. 958 // ExternalProtocolHandler::Delegate implementation.
959 virtual ShellIntegration::DefaultProtocolClientWorker* CreateShellWorker( 959 virtual ShellIntegration::DefaultProtocolClientWorker* CreateShellWorker(
960 ShellIntegration::DefaultWebClientObserver* observer, 960 ShellIntegration::DefaultWebClientObserver* observer,
961 const std::string& protocol) OVERRIDE { 961 const std::string& protocol) OVERRIDE {
962 NOTREACHED(); 962 NOTREACHED();
963 // This will crash, but it shouldn't get this far with BlockState::BLOCK 963 // This will crash, but it shouldn't get this far with BlockState::BLOCK
964 // anyway. 964 // anyway.
965 return NULL; 965 return NULL;
966 } 966 }
967 virtual ExternalProtocolHandler::BlockState GetBlockState( 967 virtual ExternalProtocolHandler::BlockState GetBlockState(
968 const std::string& scheme) OVERRIDE { 968 const std::string& scheme, bool user_gesture) OVERRIDE {
969 // Block everything and fail the test. 969 // Block everything and fail the test.
970 ADD_FAILURE(); 970 ADD_FAILURE();
971 return ExternalProtocolHandler::BLOCK; 971 return ExternalProtocolHandler::BLOCK;
972 } 972 }
973 virtual void BlockRequest() OVERRIDE { } 973 virtual void BlockRequest() OVERRIDE { }
974 virtual void RunExternalProtocolDialog(const GURL& url, 974 virtual void RunExternalProtocolDialog(const GURL& url,
975 int render_process_host_id, 975 int render_process_host_id,
976 int routing_id) OVERRIDE { 976 int routing_id) OVERRIDE {
977 NOTREACHED(); 977 NOTREACHED();
978 } 978 }
(...skipping 3068 matching lines...) Expand 10 before | Expand all | Expand 10 after
4047 } 4047 }
4048 }; 4048 };
4049 4049
4050 // Checks that prerendering works in incognito mode. 4050 // Checks that prerendering works in incognito mode.
4051 IN_PROC_BROWSER_TEST_F(PrerenderIncognitoBrowserTest, PrerenderIncognito) { 4051 IN_PROC_BROWSER_TEST_F(PrerenderIncognitoBrowserTest, PrerenderIncognito) {
4052 PrerenderTestURL("files/prerender/prerender_page.html", FINAL_STATUS_USED, 1); 4052 PrerenderTestURL("files/prerender/prerender_page.html", FINAL_STATUS_USED, 1);
4053 NavigateToDestURL(); 4053 NavigateToDestURL();
4054 } 4054 }
4055 4055
4056 } // namespace prerender 4056 } // namespace prerender
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698