Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1317813004: Don't print the dev server config if not asked. (Closed)

Created:
5 years, 3 months ago by ppi
Modified:
5 years, 3 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't print the dev server config if not asked. This patch makes the mojo tools print out the dev server config message only if `--verbose` is passed. R=qsr@google.com, qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a4f8faf06a4a5417c2e33fc57f674077511867f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M mojo/devtools/common/devtoolslib/shell_arguments.py View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben, ptal.
5 years, 3 months ago (2015-09-01 13:11:03 UTC) #1
qsr (NOT THE RIGHT qsr)
lgtm
5 years, 3 months ago (2015-09-01 13:16:34 UTC) #3
ppi
5 years, 3 months ago (2015-09-01 13:35:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4f8faf06a4a5417c2e33fc57f674077511867f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698