Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317743006: Move CSSParserSelector out of CSSParserValues.h/cpp (Closed)

Created:
5 years, 3 months ago by Timothy Loh
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move CSSParserSelector out of CSSParserValues.h/cpp Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201691

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -285 lines) Patch
M Source/core/animation/DoubleStyleInterpolation.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/core/css/parser/CSSParserSelector.h View 1 2 chunks +3 lines, -130 lines 0 comments Download
A Source/core/css/parser/CSSParserSelector.cpp View 1 chunk +121 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 2 chunks +0 lines, -57 lines 0 comments Download
M Source/core/css/parser/CSSParserValues.cpp View 2 chunks +0 lines, -94 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Timothy Loh
5 years, 3 months ago (2015-09-03 01:41:55 UTC) #2
alancutter (OOO until 2018)
rslgtm
5 years, 3 months ago (2015-09-03 01:46:13 UTC) #3
alancutter (OOO until 2018)
On 2015/09/03 at 01:46:13, alancutter wrote: > rslgtm rs lgtm
5 years, 3 months ago (2015-09-03 01:46:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317743006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317743006/20001
5 years, 3 months ago (2015-09-03 01:56:37 UTC) #6
rwlbuis
Good idea. lgtm too.
5 years, 3 months ago (2015-09-03 02:02:38 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 02:41:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201691

Powered by Google App Engine
This is Rietveld 408576698