cc: Implement shared worker contexts. (v1)

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 1004 matching lines @@
   if (!use_software) {
     context_provider = ContextProviderCommandBuffer::Create(
         CreateGraphicsContext3D(true), RENDER_COMPOSITOR_CONTEXT);
     if (!context_provider.get()) {
       // Cause the compositor to wait and try again.
       return scoped_ptr<cc::OutputSurface>();
     }
 
     worker_context_provider = ContextProviderCommandBuffer::Create(
         CreateGraphicsContext3D(false), RENDER_WORKER_CONTEXT);
-    if (!worker_context_provider.get()) {
+    if (!worker_context_provider.get() ||
+        !worker_context_provider->BindToCurrentThread()) {

[jbauman, 2015/08/26 20:59:25]

I think we want this to happen on the compositor thread, as that's where all the
callbacks will be executed.

[reveman, 2015/08/26 22:02:11]

The idea is that worker context callbacks are instead handled on the current
thread as it can be shared between compositors and other parts of chromium.
Mainly because that easier to setup as the context provider is created here and
not on the compositor thread but also to make it easier to reason about usage
from multiple threads. The context is currently only used on worker threads by
cc/ but could also be used by the media thread in the future and in that case
handling callbacks on the compositor thread seems weird.

       // Cause the compositor to wait and try again.
       return scoped_ptr<cc::OutputSurface>();
     }
+    worker_context_provider->SetupLock();
+    worker_context_provider->DetachFromThread();

[danakj, 2015/08/26 18:48:50]

ditto

[reveman, 2015/08/26 22:02:11]

Done.

   }
 
   uint32 output_surface_id = next_output_surface_id_++;
   if (command_line.HasSwitch(switches::kEnableDelegatedRenderer)) {
     DCHECK(compositor_deps_->GetCompositorImplThreadTaskRunner());
     return scoped_ptr<cc::OutputSurface>(new DelegatedCompositorOutputSurface(
         routing_id(), output_surface_id, context_provider,
         worker_context_provider, frame_swap_message_queue_));
   }
   if (!context_provider.get()) {
@@ skipping 1403 matching lines @@
 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.AddObserver(frame);
 }
 
 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.RemoveObserver(frame);
 }
 #endif  // defined(VIDEO_HOLE)
 
 }  // namespace content