Source/devtools/front_end/timeline/TimelineModel.js - Issue 1317733002: DevTools: Fix exception on timeline clear

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 1317733002: DevTools: Fix exception on timeline clear (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineModel.js

diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js

index e9077775dd163524a66a0084eefacb06fa1ee15d..f56571beaca93a2f7be3daf91deda39217b872c2 100644

--- a/Source/devtools/front_end/timeline/TimelineModel.js

+++ b/Source/devtools/front_end/timeline/TimelineModel.js

@@ -1553,7 +1553,8 @@ WebInspector.TimelineModel.buildBottomUpTree = function(topDownTree, groupingCal

/** @type {!Map<string,!WebInspector.TimelineModel.ProfileTreeNode>} */

buRoot.children = new Map();

var nodesOnStack = /** @type {!Set<string>} */ (new Set());

- topDownTree.children.forEach(processNode);

+ if (topDownTree.children)

+ topDownTree.children.forEach(processNode);

/**

* @param {!WebInspector.TimelineModel.ProfileTreeNode} tdNode

« no previous file with comments | « no previous file | no next file » | no next file with comments »