Issue 131773002: Broaden justify-self's parsing name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131773002: Broaden justify-self's parsing name (Closed)

Created:
6 years, 11 months ago by Julien - ping for review

Modified:
6 years, 11 months ago

Reviewers:
ojan

CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Broaden justify-self's parsing name This is in preparation of migrating align-self, align-items and justify-items to the CSS 3 Alignment syntax. The current naming was too tied to justify-self and needs to be broadened. This will reduce the follow-up implementations' patches. BUG=249451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164817

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -66 lines)			Patch
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSPrimitiveValueMappings.h	View	1 chunk	+36 lines, -36 lines	0 comments	Download
M	Source/core/css/parser/BisonCSSParser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/parser/BisonCSSParser-in.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyleConstants.h	View	1 chunk	+19 lines, -19 lines	0 comments	Download
M	Source/core/rendering/style/StyleRareNonInheritedData.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/131773002/1

6 years, 11 months ago (2014-01-09 21:24:06 UTC) #3

Message was sent while issue was closed.

Change committed as 164817

Expand Messages | Collapse Messages