Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1317693006: Make members of SegmentedSubstring private (Closed)

Created:
5 years, 3 months ago by kouhei (in TOK)
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make members of SegmentedSubstring private Before this CL, SegmentedSubstring::{m_length,m_data} was declared public. This CL makes them private and adds public accessors to them. BUG=None TESTS=Refactoring only. Shouldn't change any behaviour. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201221

Patch Set 1 #

Patch Set 2 : remove mysterious lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M Source/platform/text/SegmentedString.h View 1 8 chunks +22 lines, -18 lines 0 comments Download
M Source/platform/text/SegmentedString.cpp View 11 chunks +19 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kouhei (in TOK)
5 years, 3 months ago (2015-08-26 09:24:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317693006/20001
5 years, 3 months ago (2015-08-26 09:25:50 UTC) #4
haraken
LGTM
5 years, 3 months ago (2015-08-26 09:34:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-26 10:38:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317693006/20001
5 years, 3 months ago (2015-08-26 11:00:52 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 11:05:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201221

Powered by Google App Engine
This is Rietveld 408576698