Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1317683008: Include third_party/sqlite/sqlite3.h directly. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler
Modified:
5 years, 3 months ago
Reviewers:
michaeln
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Include third_party/sqlite/sqlite3.h directly. Chromium's third_party/sqlite build config arranges for third_party/sqlite to be part of the include path so that <sqlite3.h> works in these files. The system version of sqlite3.h can still be used with the use_system_sqlite build override. BUG=526828 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201600

Patch Set 1 #

Patch Set 2 : sqlite3.h dep to sqlite/DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
A Source/modules/webdatabase/sqlite/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteAuthorizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteStatement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Scott Hess - ex-Googler
I used the existing DEPS because it was most specific and seemed relevant. Stepping back, ...
5 years, 3 months ago (2015-08-31 22:56:24 UTC) #2
Scott Hess - ex-Googler
sqlite3.h dep to sqlite/DEPS
5 years, 3 months ago (2015-08-31 23:09:28 UTC) #3
Scott Hess - ex-Googler
On 2015/08/31 22:56:24, Scott Hess wrote: > I used the existing DEPS because it was ...
5 years, 3 months ago (2015-08-31 23:10:14 UTC) #4
Scott Hess - ex-Googler
Trybots look good, and this seems like one where if it compiles, it works, so ...
5 years, 3 months ago (2015-09-02 00:27:06 UTC) #5
michaeln
lgtm!
5 years, 3 months ago (2015-09-02 01:33:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317683008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317683008/20001
5 years, 3 months ago (2015-09-02 01:36:27 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 02:44:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201600

Powered by Google App Engine
This is Rietveld 408576698