Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 1317643009: X87: initialize the FPU state for X87 in prologue. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: initialize the FPU state for X87 in prologue. This CL is a fix for c0c3d866fb824290c24d4c2a14414019d844515f (r30606). In r30606, initialization of FPU implementation is not moved to prologue generation correctly. BUG= Committed: https://crrev.com/15cf7d6174b1620f5585589bc0abc3ce4a3fded6 Cr-Commit-Position: refs/heads/master@{#30626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/x87/lithium-codegen-x87.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-08 02:33:51 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-08 03:02:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317643009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317643009/1
5 years, 3 months ago (2015-09-08 03:03:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 03:27:16 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 03:27:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15cf7d6174b1620f5585589bc0abc3ce4a3fded6
Cr-Commit-Position: refs/heads/master@{#30626}

Powered by Google App Engine
This is Rietveld 408576698