third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox.html - Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox.html

Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing. Removed unused params Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/relayout-indefinite-heights-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox.html b/third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox.html

index 1bbbedef6fc10762404f343eeaa3be07424d6b7c..523a572460f8ab74b13561b6e915f3c6fe0a2cfc 100644

--- a/third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox.html

+++ b/third_party/WebKit/LayoutTests/fast/events/key-events-in-editable-gridbox.html

@@ -1,14 +1,19 @@

<!DOCTYPE html>

<style>

- #target {

- display: grid;

- display: -webkit-grid;

- }

+.grid { display: grid; }

+.intrinsicSize { height: -webkit-min-content; }

+.fixedSize { height: 1px; }

</style>

-<div id="target" contentEditable>T</div>

+<div id="targetAuto" class="grid" contentEditable>T</div>

+<div id="targetFixed" class="grid fixedSize" contentEditable>T</div>

+<div id="targetIntrinsic" class="grid intrinsicSize" contentEditable>T</div>

- var targetDiv = document.getElementById('target');

+var targetDiv;

+function runEditTest(id) {

+ targetDiv = document.getElementById(id);

targetDiv.focus();

// Move cursor to the end of line.

@@ -25,4 +30,10 @@

document.execCommand("insertText", false, "TEST");

shouldBeEqualToString("targetDiv.innerText", "TEST");

+runEditTest('targetAuto');

+runEditTest('targetFixed');

+runEditTest('targetIntrinsic');

</script>