Source/core/layout/LayoutGrid.h - Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutGrid.h

Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html ('K') | « LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html ('k') | Source/core/layout/LayoutGrid.cpp » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutGrid.h

diff --git a/Source/core/layout/LayoutGrid.h b/Source/core/layout/LayoutGrid.h

index 275673d0f5ecb085af173ef03745e13f3a72853a..286000b02aa36098e911165fb5debbaa6cb823fa 100644

--- a/Source/core/layout/LayoutGrid.h

+++ b/Source/core/layout/LayoutGrid.h

@@ -105,7 +105,6 @@ private:

class GridIterator;

struct GridSizingData;

- bool gridElementIsShrinkToFit();

void computeUsedBreadthOfGridTracks(GridTrackSizingDirection, GridSizingData&, LayoutUnit& availableLogicalSpace);

LayoutUnit computeUsedBreadthOfMinLength(GridTrackSizingDirection, const GridLength&) const;

LayoutUnit computeUsedBreadthOfMaxLength(GridTrackSizingDirection, const GridLength&, LayoutUnit usedBreadth) const;

@@ -186,6 +185,7 @@ private:

}

bool hasDefiniteLogicalSize(GridTrackSizingDirection) const;

+ void maximizeTracks(Vector<GridTrack>&, GridSizingData&, LayoutUnit& spaceToDistribute);

typedef Vector<Vector<GridCell>> GridRepresentation;

GridRepresentation m_grid;