Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html

Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html ('K') | « LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html ('k') | LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height-expected.txt » ('j') | LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
diff --git a/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html b/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
new file mode 100644
index 0000000000000000000000000000000000000000..b4e3f7f1480e2da4e2e21910b21436f4f422fa9c
--- /dev/null
+++ b/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
@@ -0,0 +1,173 @@
+<!DOCTYPE html>
+
+<link href="resources/grid.css" rel="stylesheet">
+<link href="../css-intrinsic-dimensions/resources/height-keyword-classes.css" rel="stylesheet">
+
+<style>
+.grid {
+ grid-template-rows: minmax(0px, 100px);
+ width: 40px;
+
+ align-items: start;
+ justify-items: start;
+}
+
+.max-height-35 { max-height: 35px; }
+.max-height-50 { max-height: 50px; }
+.min-height-35 { min-height: 35px; }
+.min-height-50 { min-height: 50px; }
+</style>
+
+<script src="../../resources/check-layout.js"></script>
+
+<body onload="checkLayout('.grid')">
+
+<h2>Check the behavior of grids under max-content constraints.</h2>
+<div class="grid max-content max-height-35" data-expected-width="40" data-expected-height="35">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="35">XX XXX XX XXX</div>
jfernandez 2015/09/01 23:41:39 I don't get the 'sizedToGridArea' because that's w
svillar 2015/09/02 13:25:48 Hmm good point, I should have done it for some rea
Manuel Rego 2015/09/17 11:04:02 You're using "align|justify-items: start;" before,
svillar 2015/09/17 14:05:44 Yeah, that's it. The patch is a bit old, so I forg
+</div>
+
+<div class="grid max-content max-height-min-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XXX X</div>
+</div>
+
+<div class="grid max-height-min-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XXX</div>
+</div>
+
+<div class="grid max-content max-height-fill-available" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XXX X XXX</div>
+</div>
+
+<div class="grid max-content" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX XXX XX</div>
+</div>
+
+<br>
+<h2>Check the behavior of grids under min-content contstraints.</h2>
+<div class="grid min-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XX XX</div>
+</div>
+
+<div class="grid min-content min-height-50" data-expected-width="40" data-expected-height="50">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="50">XX X</div>
+</div>
+
+<div class="grid min-content min-height-fit-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XXX XXXX</div>
+</div>
+
+<div style="height: 200px;">
+ <div class="grid min-content min-height-fill-available" data-expected-width="40" data-expected-height="200">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXXX XXXX XXX</div>
+ </div>
+</div>
+
+<div class="grid min-content min-height-min-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XXX</div>
+</div>
+
+<div class="grid min-content min-height-35" data-expected-width="40" data-expected-height="35">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="35">XX XX</div>
+</div>
+
+<div class="grid min-content min-height-max-content" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">X XXX X</div>
+</div>
+
+<div class="grid min-content min-height-50" data-expected-width="40" data-expected-height="50">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="50">XXXX XXXX XXXX XXXX</div>
+</div>
Manuel Rego 2015/09/17 11:04:02 This seems a duplicated test comparing it with lin
+
+<div class="grid min-content max-height-50" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea min-height-fill-available" data-expected-width="40" data-expected-height="50">XXXX X X XXXX</div>
+</div>
+
+<br>
+<h2>Check the behavior of grids with definite available space.</h2>
+<div class="grid" style="height: 100px;" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX X</div>
+</div>
+
+<div class="grid max-height-35" style="height: 100px;" data-expected-width="40" data-expected-height="35">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="35">XX XX</div>
+</div>
+
+<div class="grid min-height-50" style="height: 10px;" data-expected-width="40" data-expected-height="50">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="50">XX XXXX</div>
+</div>
+
+<div class="grid min-height-50" style="height: 20px; data-expected-width="40" data-expected-height="50">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="50">XX XXX XX XXX XX XXX</div>
+</div>
+
+<div style="height: 100px;">
+ <div class="grid" style="height: 37%;" data-expected-width="40" data-expected-height="37">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="37">X X X X</div>
+ </div>
+ <div class="grid min-height-50" style="height: 37%;" data-expected-width="40" data-expected-height="50">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="50">XX XX XX</div>
+ </div>
+ <div class="grid min-height-35" style="height: 37%;" data-expected-width="40" data-expected-height="37">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="37">XXXX</div>
+ </div>
+</div>
+
+<br>
+<h2>Check the behavior of grids with indefinite available space.</h2>
+<div class="fit-content">
+ <div class="grid" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX</div>
+ </div>
+ <div class="grid min-height-35" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">X XXXX X</div>
+ </div>
+ <div class="grid max-height-min-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XX XX</div>
+ </div>
+ <div class="grid fit-content" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">X XX X</div>
+ </div>
+</div>
+
+<div class="fit-content" style="height: 125px;">
+ <div class="grid fill-available" data-expected-width="40" data-expected-height="125">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">X XX X</div>
+ </div>
+</div>
+
+<div class="fit-content min-height-50">
+ <div class="grid" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XXXX XX X XXX</div>
+ </div>
+ <div class="grid min-height-35" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XXXX X X</div>
+ </div>
+ <div class="grid max-height-min-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">X XXX XX</div>
+ </div>
+ <div class="grid fit-content" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX XX X</div>
+ </div>
+</div>
+
+<div class="fit-content min-height-50" style="height: 75px;">
+ <div class="grid fill-available" data-expected-width="40" data-expected-height="75">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
+ </div>
+</div>
+
+<div style="height: 25px;">
+ <div class="grid fit-content" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
+ </div>
+ <div class="grid fill-available" data-expected-width="40" data-expected-height="25">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
+ </div>
+ <div class="grid fit-content min-height-35" data-expected-width="40" data-expected-height="100">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
+ </div>
+ <div class="grid fit-content max-height-min-content" data-expected-width="40" data-expected-height="0">
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX X</div>
+ </div>
+</div>
« LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html ('K') | « LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html ('k') | LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height-expected.txt » ('j') | LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698