third_party/WebKit/LayoutTests/fast/css-grid-layout/relayout-indefinite-heights.html - Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/relayout-indefinite-heights.html

Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing. Removed unused params Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/relayout-indefinite-heights-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <link href="resources/grid.css" rel="stylesheet">

	3 <style>

	4 .grid {

	5 grid: 50px / minmax(5px, 1fr) minmax(5px, 2fr);

	6 }

	7

	8 #fromIndefinite { height: auto; }

	9 #toIndefinite { height: 90px; }

	10 </style>

	11 <script src="../../resources/check-layout.js"></script>

	12 <p>Tests how a change in grid's height requires evaluating again whether the gri d has indefinite or definite height.</p>

	13

	14 <p>The grid bellow had initially 'height: auto' (indefinite) and has been change d to '90px' (definite).</p>

	15 <div class="constrainedContainer">

	16 <div id="fromIndefinite" class="grid">

	17 <div class="firstRowFirstColumn" data-expected-width="50" data-expected- height="30"></div>

	18 <div class="secondRowFirstColumn" data-expected-width="50" data-expected -height="60"></div>

	19 </div>

	20 </div>

	21

	22 <hr style="margin-top: 150px;">

	23

	24 <p>The grid bellow had initially 'height: 90px' (definite) and has been changed to 'auto' (indefinite).</p>

	25 <div class="constrainedContainer">

	26 <div id="toIndefinite" class="grid">

	27 <div class="firstRowFirstColumn" data-expected-width="50" data-expected- height="5"></div>

	28 <div class="secondRowFirstColumn" data-expected-width="50" data-expected -height="10"></div>

	29 </div>

	30 </div>

	31

	32 <script>

	33 document.body.offsetLeft;

	34 document.getElementById("toIndefinite").style.height = "auto";

	35 document.getElementById("fromIndefinite").style.height = "90px";

	36 checkLayout(".grid");

	37 </script>

OLD	NEW