LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html - Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html

Issue 1317643005: [css-grid] Fix track sizing algo w/ size restrictions and intrinsic sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html ('K') | « LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-width-expected.txt ('k') | Source/core/layout/LayoutGrid.h » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <link href="resources/grid.css" rel="stylesheet">	2 <link href="resources/grid.css" rel="stylesheet">

3 <style>	3 <style>

4 .indefiniteSizeGrid {	4 .indefiniteSizeGrid {

5 font: 10px/1 Ahem;	5 font: 10px/1 Ahem;

	6 width: -webkit-min-content;
	jfernandez 2015/09/01 23:41:39 Same question than before. Same question than before. svillar 2015/09/02 13:25:48 Same reply Show quoted text On 2015/09/01 23:41:39, jfernandez wrote: > Same question than before. Same reply
6 }	7 }

7 .gridWithPercent {	8 .gridWithPercent {

8 grid-template-columns: 25%;	9 grid-template-columns: 25%;

9 grid-template-rows: 30%;	10 grid-template-rows: 30%;

10 }	11 }

11 .gridWithPercentInMinOfMinMax {	12 .gridWithPercentInMinOfMinMax {

12 grid-template-columns: minmax(20%, max-content);	13 grid-template-columns: minmax(20%, max-content);

13 grid-template-rows: minmax(100%, 15px);	14 grid-template-rows: minmax(100%, 15px);

14 }	15 }

15 .gridWithPercentInMinOfMinMax2 {	16 .gridWithPercentInMinOfMinMax2 {

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 <div class="indefiniteSizeGrid gridWithPercentInMaxOfMinMax2" data-expected- width="20" data-expected-height="20">	59 <div class="indefiniteSizeGrid gridWithPercentInMaxOfMinMax2" data-expected- width="20" data-expected-height="20">

59 <div class="firstRowFirstColumn">XXXX<br>X</div>	60 <div class="firstRowFirstColumn">XXXX<br>X</div>

60 </div>	61 </div>

61 </div>	62 </div>

62 <div style="position: relative;">	63 <div style="position: relative;">

63 <div class="indefiniteSizeGrid gridWithPercentsInMinMax" data-expected-width ="40" data-expected-height="40">	64 <div class="indefiniteSizeGrid gridWithPercentsInMinMax" data-expected-width ="40" data-expected-height="40">

64 <div class="firstRowFirstColumn">XXX<br>XX XX<br>XXXX</div>	65 <div class="firstRowFirstColumn">XXX<br>XX XX<br>XXXX</div>

65 </div>	66 </div>

66 </div>	67 </div>

67 </body>	68 </body>

OLD	NEW