Source/web/WebMediaPlayerClientImpl.h - Issue 131763011: Expose the poster image URL to WebMediaPlayer subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.h

Issue 131763011: Expose the poster image URL to WebMediaPlayer subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed Anton & Aaron's comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebMediaPlayerClientImpl.h

diff --git a/Source/web/WebMediaPlayerClientImpl.h b/Source/web/WebMediaPlayerClientImpl.h

index 8b38af927ff8ef0bbce6e992a6e9fc3b9c116640..93313276301b4e9cfe3ff5a3fb7e621e3747883d 100644

--- a/Source/web/WebMediaPlayerClientImpl.h

+++ b/Source/web/WebMediaPlayerClientImpl.h

@@ -48,6 +48,7 @@

namespace WebCore {

class AudioSourceProviderClient;

+class KURL;

acolwell GONE FROM CHROMIUM 2014/02/06 22:53:50 nit: You shouldn't need this since 7 lines up ther

cimamoglu (inactive) 2014/02/07 14:36:19 Done.

}

namespace blink {

@@ -113,6 +114,7 @@ public:

virtual bool paused() const OVERRIDE;

virtual void setVolume(double) OVERRIDE;

virtual void setMuted(bool) OVERRIDE;

+ virtual void setPoster(const WebCore::KURL&) OVERRIDE;

virtual WebCore::MediaPlayer::NetworkState networkState() const OVERRIDE;

virtual WebCore::MediaPlayer::ReadyState readyState() const OVERRIDE;

virtual double maxTimeSeekable() const OVERRIDE;

« no previous file with comments | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/web/WebMediaPlayerClientImpl.cpp » ('j') | Source/web/WebMediaPlayerClientImpl.cpp » ('J')