Issue 131763007: Fixes sizing issue when dragging tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131763007: Fixes sizing issue when dragging tabs (Closed)

Created:
6 years, 10 months ago by sky

Modified:
6 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes sizing issue when dragging tabs To avoid unnecessary layout (and stopping of animations) TabStrip caches the last size it layed out. During drag and drop of tabs SetTabBoundsForDrag may be used to force a particular tab size/location. After a call to SetTabBoundsForDrag we need to ensure the tabstrip does in fact relayout next time Layout() is invoked. By clearing last_layaout_size_ we ensure this happens. BUG=338617 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247619

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/tabs/tab_strip.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/131763007/1

6 years, 10 months ago (2014-01-29 00:24:31 UTC) #3

Message was sent while issue was closed.

Change committed as 247619

Expand Messages | Collapse Messages