Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 13176002: factor out "ReloadContextFromFrame" (Closed)

Created:
7 years, 8 months ago by wingo
Modified:
7 years, 8 months ago
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

factor out "ReloadContextFromFrame" * src/arm/macro-assembler-x64.h: * src/ia32/macro-assembler-ia32.h: * src/x64/macro-assembler-arm.h: * src/arm/macro-assembler-arm.cc (ReloadContextFromFrame): * src/ia32/macro-assembler-ia32.cc (ReloadContextFromFrame): * src/x64/macro-assembler-x64.cc (ReloadContextFromFrame): New helper. Will let more code be backend-agnostic. * src/arm/full-codegen-x64.h: * src/ia32/full-codegen-ia32.h: * src/x64/full-codegen-arm.h: Use the new helper. ia32 and arm are untested. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -36 lines) Patch
M src/arm/full-codegen-arm.cc View 6 chunks +6 lines, -11 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 7 chunks +7 lines, -12 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 8 chunks +8 lines, -13 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
Hi, A little refactor that I had. Let me know what you think. Andy
7 years, 8 months ago (2013-03-28 15:13:41 UTC) #1
Michael Starzinger
I am not sure whether this is the right level of abstraction. I am happy ...
7 years, 8 months ago (2013-04-08 11:35:29 UTC) #2
wingo
On 2013/04/08 11:35:29, Michael Starzinger wrote: > I am not sure whether this is the ...
7 years, 8 months ago (2013-04-08 11:47:07 UTC) #3
wingo
7 years, 8 months ago (2013-04-08 15:39:04 UTC) #4
Let's close this one.  If we end up doing some kind of refactoring here, I guess
it should be part of a patch that demonstrates the utility of the refactor in
use sites that are actually adding features.

Powered by Google App Engine
This is Rietveld 408576698