Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1317593004: Clean up SkTLogic. (Closed)

Created:
5 years, 3 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up SkTLogic. This change regularizes Skia's type traits so that when <type_traits> can finally be used the transition is easier. Various traits are renamed to match <type_traits> and placed in the skstd namespace. Current users of these traits are updated. Committed: https://skia.googlesource.com/skia/+/761cf6186e291ee8e4761e1280634cfe9c42eccc

Patch Set 1 #

Patch Set 2 : Remove redundant 'public'. #

Patch Set 3 : Remove no longer true comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -165 lines) Patch
M include/gpu/GrBlend.h View 6 chunks +28 lines, -28 lines 0 comments Download
M include/private/SkTLogic.h View 1 2 3 chunks +99 lines, -98 lines 0 comments Download
M include/private/SkTemplates.h View 2 chunks +2 lines, -14 lines 0 comments Download
M src/core/SkRecord.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkTFitsIn.h View 11 chunks +30 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317593004/1
5 years, 3 months ago (2015-08-27 19:54:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317593004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317593004/20001
5 years, 3 months ago (2015-08-27 19:58:17 UTC) #4
bungeman-skia
5 years, 3 months ago (2015-08-27 20:02:16 UTC) #6
mtklein
lgtm
5 years, 3 months ago (2015-08-27 20:29:11 UTC) #7
bsalomon
lgtm
5 years, 3 months ago (2015-08-27 23:03:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317593004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317593004/40001
5 years, 3 months ago (2015-08-28 14:04:07 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 14:09:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/761cf6186e291ee8e4761e1280634cfe9c42eccc

Powered by Google App Engine
This is Rietveld 408576698