Have SSLErrorHandler decide which type of interstitial to display

chrome/browser/ssl/bad_clock_blocking_page.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/bad_clock_blocking_page.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/build_time.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/i18n/time_formatting.h"
 #include "base/process/launch.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/interstitials/chrome_metrics_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_preferences_util.h"
 #include "chrome/browser/ssl/ssl_error_classification.h"
 #include "chrome/browser/ssl/ssl_error_info.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/google/core/browser/google_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cert_store.h"
@@ skipping 30 matching lines @@
 
 using base::ASCIIToUTF16;
 using base::TimeTicks;
 using content::InterstitialPage;
 using content::InterstitialPageDelegate;
 using content::NavigationController;
 using content::NavigationEntry;
 
 namespace {
 
+const char kMetricsName[] = "bad_clock";
+
 void LaunchDateAndTimeSettings() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);
 // The code for each OS is completely separate, in order to avoid bugs like
 // https://crbug.com/430877 .
 #if defined(OS_ANDROID)
   chrome::android::OpenDateAndTimeSettings();
 
 #elif defined(OS_CHROMEOS)
   std::string sub_page =
       std::string(chrome::kSearchSubPage) + "#" +
@@ skipping 87 matching lines @@
     content::WebContents* web_contents,
     int cert_error,
     const net::SSLInfo& ssl_info,
     const GURL& request_url,
     const base::Time& time_triggered,
     const base::Callback<void(bool)>& callback)
     : SecurityInterstitialPage(web_contents, request_url),
       callback_(callback),
       cert_error_(cert_error),
       ssl_info_(ssl_info),
-      time_triggered_(time_triggered) {}
+      time_triggered_(time_triggered) {
+  security_interstitials::MetricsHelper::ReportDetails reporting_info;
+  reporting_info.metric_prefix = kMetricsName;
+  set_metrics_helper(new ChromeMetricsHelper(web_contents, request_url,
+                                             reporting_info, kMetricsName));
+  metrics_helper()->RecordUserInteraction(
+      security_interstitials::MetricsHelper::TOTAL_VISITS);
+
+  // TODO(felt): Separate the clock statistics from the main ssl statistics.
+  (new SSLErrorClassification(web_contents, time_triggered_, request_url,

[estark, 2015/09/01 16:41:48]

memory leak... put it in a scoped_ptr or just do

SSLErrorClassification error_classification(...);
error_classification->RecordUMAStatistics(false);

[felt, 2015/09/01 19:13:15]

Done.

+                              cert_error_, *ssl_info_.cert.get()))
+      ->RecordUMAStatistics(false);
+}
 
 bool BadClockBlockingPage::ShouldCreateNewNavigation() const {
   return true;
 }
 
 InterstitialPageDelegate::TypeID BadClockBlockingPage::GetTypeForTesting()
     const {
   return BadClockBlockingPage::kTypeForTesting;
 }
 
@@ skipping 96 matching lines @@
     case CMD_DONT_PROCEED:
       interstitial_page()->DontProceed();
       break;
     case CMD_DO_REPORT:
       SetReportingPreference(true);
       break;
     case CMD_DONT_REPORT:
       SetReportingPreference(false);
       break;
     case CMD_SHOW_MORE_SECTION:
+      metrics_helper()->RecordUserInteraction(
+          security_interstitials::MetricsHelper::SHOW_ADVANCED);
       break;
     case CMD_OPEN_DATE_SETTINGS:
+      metrics_helper()->RecordUserInteraction(
+          security_interstitials::MetricsHelper::OPEN_TIME_SETTINGS);
       content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE,
                                        base::Bind(&LaunchDateAndTimeSettings));
       break;
     case CMD_OPEN_REPORTING_PRIVACY:
       OpenExtendedReportingPrivacyPolicy();
       break;
     case CMD_PROCEED:
     case CMD_OPEN_HELP_CENTER:
     case CMD_RELOAD:
     case CMD_OPEN_DIAGNOSTIC:
@@ skipping 16 matching lines @@
 
 void BadClockBlockingPage::NotifyDenyCertificate() {
   // It's possible that callback_ may not exist if the user clicks "Proceed"
   // followed by pressing the back button before the interstitial is hidden.
   // In that case the certificate will still be treated as allowed.
   if (callback_.is_null())
     return;
 
   base::ResetAndReturn(&callback_).Run(false);
 }