Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1317563005: Fix binary size increase because of class name loading. (Closed)

Created:
5 years, 3 months ago by ssid
Modified:
5 years, 3 months ago
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix binary size increase because of class name loading. This CL puts the classname under GC_PROFILING flag since it increases binary size in production builds. BUG=527054 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201671

Patch Set 1 #

Patch Set 2 : fix build. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M Source/platform/heap/GCInfo.h View 2 chunks +5 lines, -1 line 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 1 chunk +4 lines, -1 line 1 comment Download
M Source/platform/heap/Visitor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/wtf/InstanceCounter.h View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/wtf/InstanceCounter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ssid
PTAL, Thanks.
5 years, 3 months ago (2015-09-02 13:14:59 UTC) #2
haraken
LGTM, thanks for the fix! It's unfortunate that we can't visualize class names in memory-infra ...
5 years, 3 months ago (2015-09-02 13:36:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317563005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317563005/20001
5 years, 3 months ago (2015-09-02 22:02:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201671
5 years, 3 months ago (2015-09-02 22:07:23 UTC) #7
kouhei (in TOK)
lgtm
5 years, 3 months ago (2015-09-02 22:41:03 UTC) #8
sof
5 years, 3 months ago (2015-09-03 07:14:20 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1317563005/diff/20001/Source/platform/heap/Th...
File Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/1317563005/diff/20001/Source/platform/heap/Th...
Source/platform/heap/ThreadState.cpp:1498: dumpName +=
Heap::gcInfo(gcInfoIndex)->className();
Did this compile? We don't provide += over String, right?

(Addressed by https://codereview.chromium.org/1308053007/ )

Powered by Google App Engine
This is Rietveld 408576698