Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 1317533003: Revert of cc: Move worker context BindToCurrentThread/SetupLock calls out of cc::OutputSurface. (Closed)

Created:
5 years, 3 months ago by jbauman
Modified:
5 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, boliu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Move worker context BindToCurrentThread/SetupLock calls out of cc::OutputSurface. (patchset #5 id:80001 of https://codereview.chromium.org/1317743002/ ) Reason for revert: Likely causes crash on Mac: https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%29/builds/54667 Going to see if reverting helps. BUG=527186 Original issue's description: > cc: Move worker context BindToCurrentThread/SetupLock calls out of cc::OutputSurface. > > This moves the responsibility to call these functions from > cc:OutputSurface to the code that creates the context. > > BUG=523411 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/10b73d7c140bc67ddeeaf716eb31df0977fe2497 > Cr-Commit-Position: refs/heads/master@{#346712} TBR=avi@chromium.org,danakj@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=523411 Committed: https://crrev.com/8ba593f708c15ff3a9e0fce6a8bb8da1f80dec3b Cr-Commit-Position: refs/heads/master@{#346736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -80 lines) Patch
M cc/output/output_surface.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/test/fake_output_surface.h View 3 chunks +8 lines, -10 lines 0 comments Download
M cc/test/test_context_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/test_context_provider.cc View 1 chunk +1 line, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/compositor/test/in_process_context_provider.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/compositor/test/in_process_context_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbauman
Created Revert of cc: Move worker context BindToCurrentThread/SetupLock calls out of cc::OutputSurface.
5 years, 3 months ago (2015-09-01 21:19:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317533003/1
5 years, 3 months ago (2015-09-01 21:19:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 21:20:33 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 21:21:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ba593f708c15ff3a9e0fce6a8bb8da1f80dec3b
Cr-Commit-Position: refs/heads/master@{#346736}

Powered by Google App Engine
This is Rietveld 408576698