Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: Source/core/css/invalidation/StyleInvalidator.h

Issue 1317533002: Sibling invalidation sets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/invalidation/StyleInvalidator.h
diff --git a/Source/core/css/invalidation/StyleInvalidator.h b/Source/core/css/invalidation/StyleInvalidator.h
index 477be9d513344669ee556f639aba13f64e13eaa5..ee42b5b2cd53388c1741516339dcaa87d30e2b5b 100644
--- a/Source/core/css/invalidation/StyleInvalidator.h
+++ b/Source/core/css/invalidation/StyleInvalidator.h
@@ -5,14 +5,15 @@
#ifndef StyleInvalidator_h
#define StyleInvalidator_h
+#include "core/css/invalidation/InvalidationLists.h"
#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
namespace blink {
-class InvalidationSet;
class Document;
class Element;
+class InvalidationSet;
class StyleInvalidator {
DISALLOW_ALLOCATION();
@@ -21,7 +22,7 @@ public:
StyleInvalidator();
~StyleInvalidator();
void invalidate(Document&);
- void scheduleInvalidation(PassRefPtrWillBeRawPtr<InvalidationSet>, Element&);
+ void scheduleInvalidationSetsForElement(const InvalidationLists&, Element&);
void clearInvalidation(Element&);
void clearPendingInvalidations();
@@ -38,7 +39,7 @@ private:
{ }
void pushInvalidationSet(const InvalidationSet&);
- bool matchesCurrentInvalidationSets(Element&);
+ bool matchesCurrentInvalidationSets(Element&) const;
bool hasInvalidationSets() const { return !wholeSubtreeInvalid() && m_invalidationSets.size(); }
bool wholeSubtreeInvalid() const { return m_wholeSubtreeInvalid; }
@@ -55,9 +56,35 @@ private:
bool m_insertionPointCrossing;
};
- bool invalidate(Element&, RecursionData&);
+ class SiblingData {
+ STACK_ALLOCATED();
+ public:
+ SiblingData()
+ : m_elementIndex(0)
+ { }
+
+ void pushInvalidationSet(const InvalidationSet&);
+ bool matchCurrentInvalidationSets(Element&, RecursionData&);
+
+ void advance() { m_elementIndex++; }
+
+ struct Entry {
+ Entry(const InvalidationSet* invalidationSet, unsigned invalidationLimit)
+ : m_invalidationSet(invalidationSet)
+ , m_invalidationLimit(invalidationLimit)
+ {}
+
+ RawPtrWillBeMember<const InvalidationSet> m_invalidationSet;
+ unsigned m_invalidationLimit;
+ };
+
+ WillBeHeapVector<Entry, 16> m_invalidationEntries;
+ unsigned m_elementIndex;
+ };
+
+ bool invalidate(Element&, RecursionData&, SiblingData&);
bool invalidateChildren(Element&, RecursionData&);
- bool checkInvalidationSetsAgainstElement(Element&, RecursionData&);
+ bool checkInvalidationSetsAgainstElement(Element&, RecursionData&, SiblingData&);
class RecursionCheckpoint {
public:
@@ -87,10 +114,9 @@ private:
RecursionData* m_data;
};
- using InvalidationList = WillBeHeapVector<RefPtrWillBeMember<InvalidationSet>>;
- using PendingInvalidationMap = WillBeHeapHashMap<RawPtrWillBeMember<Element>, OwnPtrWillBeMember<InvalidationList>>;
+ using PendingInvalidationMap = WillBeHeapHashMap<RawPtrWillBeMember<Element>, OwnPtrWillBeMember<InvalidationLists>>;
- InvalidationList& ensurePendingInvalidationList(Element&);
+ InvalidationLists& ensurePendingInvalidationLists(Element&);
PendingInvalidationMap m_pendingInvalidationMap;
};

Powered by Google App Engine
This is Rietveld 408576698