Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/fast/css/invalidation/compound.html

Issue 1317533002: Sibling invalidation sets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/invalidation/class-sibling-universal.html ('k') | LayoutTests/fast/css/invalidation/compound-expected.txt » ('j') | Source/core/css/invalidation/InvalidationData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css/invalidation/compound.html
diff --git a/LayoutTests/fast/css/invalidation/compound.html b/LayoutTests/fast/css/invalidation/compound.html
index 80651a0dd8136a8f1845a5997f0dc72e2ad90a1b..81a1c30fcb8c237333521ca6645037dbc8fdac03 100644
--- a/LayoutTests/fast/css/invalidation/compound.html
+++ b/LayoutTests/fast/css/invalidation/compound.html
@@ -130,7 +130,7 @@ test(function() {
assert_equals(getComputedStyle(r1).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t1.className = "t1";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 5, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 4, "Subtree style recalc");
assert_equals(getComputedStyle(r1).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Descendant with compound selector containing id");
@@ -138,7 +138,7 @@ test(function() {
assert_equals(getComputedStyle(r2).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t2.className = "t2";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 3, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 2, "Subtree style recalc");
assert_equals(getComputedStyle(r2).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Descendant with compound selector containing universal and id");
@@ -146,7 +146,7 @@ test(function() {
assert_equals(getComputedStyle(r3).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t3.className = "t3";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 4, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 3, "Subtree style recalc");
assert_equals(getComputedStyle(r3).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Descendant with compound selector");
@@ -154,7 +154,7 @@ test(function() {
assert_equals(getComputedStyle(r4).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t4.className = "t4";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 4, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 3, "Subtree style recalc");
assert_equals(getComputedStyle(r4).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Descendant with compound selector containing universal");
@@ -163,7 +163,7 @@ test(function() {
assert_equals(getComputedStyle(r5b).backgroundColor, "rgba(0, 0, 0, 0)", "Background color b should initially be transparent");
t5.className = "t5";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 6, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 5, "Subtree style recalc");
assert_equals(getComputedStyle(r5a).backgroundColor, "rgb(0, 128, 0)", "Background color a is green after class change");
assert_equals(getComputedStyle(r5b).backgroundColor, "rgb(0, 128, 0)", "Background color b is green after class change");
}, "Descendant with :-webkit-any containing compound selector");
@@ -172,7 +172,7 @@ test(function() {
assert_equals(getComputedStyle(r6).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t6.className = "t6";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 6, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 4, "Subtree style recalc");
assert_equals(getComputedStyle(r6).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Sibling with compound descendant containing id");
@@ -180,8 +180,7 @@ test(function() {
assert_equals(getComputedStyle(r7).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t7.className = "t7";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 1, "Subtree style recalc");
- // TODO(ericwilligers): Update Blink's implementation of sibling selector invalidation, so the following passes:
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 3, "Subtree style recalc");
assert_equals(getComputedStyle(r7).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Sibling with compound descendant");
@@ -189,7 +188,7 @@ test(function() {
assert_equals(getComputedStyle(r8).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t8.className = "t8";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 11, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 4, "Subtree style recalc");
assert_equals(getComputedStyle(r8).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Compound sibling selector containing id");
@@ -197,7 +196,7 @@ test(function() {
assert_equals(getComputedStyle(r9).backgroundColor, "rgba(0, 0, 0, 0)", "Background color should initially be transparent");
t9.className = "t9";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 9, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 3, "Subtree style recalc");
assert_equals(getComputedStyle(r9).backgroundColor, "rgb(0, 128, 0)", "Background color is green after class change");
}, "Compound sibling selector");
@@ -206,7 +205,7 @@ test(function() {
assert_equals(getComputedStyle(r10b).backgroundColor, "rgba(0, 0, 0, 0)", "Background color b should initially be transparent");
t10.className = "t10";
- assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 9, "Subtree style recalc");
+ assert_equals(internals.updateStyleAndReturnAffectedElementCount(), 5, "Subtree style recalc");
assert_equals(getComputedStyle(r10a).backgroundColor, "rgb(0, 128, 0)", "Background color a is green after class change");
assert_equals(getComputedStyle(r10b).backgroundColor, "rgb(0, 128, 0)", "Background color b is green after class change");
}, "Sibling with descendant :-webkit-any containing compound selector");
« no previous file with comments | « LayoutTests/fast/css/invalidation/class-sibling-universal.html ('k') | LayoutTests/fast/css/invalidation/compound-expected.txt » ('j') | Source/core/css/invalidation/InvalidationData.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698