LayoutTests/fast/layout/display-none-no-relayout.html - Issue 1317533002: Sibling invalidation sets

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/layout/display-none-no-relayout.html

Issue 1317533002: Sibling invalidation sets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/invalidation/targeted-id-style-invalidation-expected.txt ('k') | LayoutTests/media/track/cue-style-invalidation.html » ('j') | Source/core/css/invalidation/InvalidationData.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <style>	3 <style>

4 .a span {}	4 .a span {}

5 </style>	5 </style>

6 <div id="parent">	6 <div id="parent">

7 <span style="display:none"></span>	7 <span style="display:none"></span>

8 <div style="float:left;"></div>	8 <div style="float:left;"></div>

9 <span></span>	9 <span></span>

10 </div>	10 </div>

11 <script>	11 <script>

12 // Force style recalc and layout.	12 // Force style recalc and layout.

13 document.body.offsetTop;	13 document.body.offsetTop;

14	14

15 if (window.internals)	15 if (window.internals)

16 shouldBe("window.internals.needsLayoutCount()", "0", true);	16 shouldBe("window.internals.needsLayoutCount()", "0", true);

17	17

18 var parent = document.getElementById("parent");	18 var parent = document.getElementById("parent");

19	19

20 // Changing the class attribute here will cause a style recalc with a resulting	20 // Changing the class attribute here will cause a style recalc with a resulting

21 // reattach, but it should not cause a relayout.	21 // reattach, but it should not cause a relayout.

22 parent.className = "a";	22 parent.className = "a";

23	23

24 if (window.internals) {	24 if (window.internals) {

25 shouldBe("window.internals.updateStyleAndReturnAffectedElementCount()", "3", true);	25 shouldBe("window.internals.updateStyleAndReturnAffectedElementCount()", "2", true);

26 shouldBe("window.internals.needsLayoutCount()", "0", true);	26 shouldBe("window.internals.needsLayoutCount()", "0", true);

27 }	27 }

28 </script>	28 </script>

OLD	NEW