Sibling invalidation sets

Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

 /*
  * Copyright (C) 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 43 matching lines @@
             // Prefer ids over classes.
             if (current->match() == CSSSelector::Id)
                 scopeSelector = current;
             else if (current->match() == CSSSelector::Class && (!scopeSelector || scopeSelector->match() != CSSSelector::Id))
                 scopeSelector = current;
             CSSSelector::Relation relation = current->relation();
             // FIXME: it would be better to use setNeedsStyleRecalc for all shadow hosts matching
             // scopeSelector. Currently requests full style recalc.
             if (relation == CSSSelector::ShadowDeep || relation == CSSSelector::ShadowPseudo)
                 return false;
-            if (relation != CSSSelector::Descendant && relation != CSSSelector::Child && relation != CSSSelector::SubSelector)

[Timothy Loh, 2015/09/10 06:09:40]

This doesn't seem related?

[rune, 2015/09/10 13:54:50]

This might actually work with the current code given that
maxDirectAdjacentSelectors is up-to-date with the new stylesheet when the
SubtreeStyleChange set in StyleSheetInvalidationAnalysis::invalidateStyle
triggers sibling recalcs in
ContainerNode::checkForChildrenAdjacentRuleChanges().

But, it should be a different CL in either case.

[Eric Willigers, 2015/09/14 07:20:24]

Reverted, it isn't needed.

-                break;
         }
         if (!scopeSelector)
             return false;
         ASSERT(scopeSelector->match() == CSSSelector::Class || scopeSelector->match() == CSSSelector::Id);
         if (scopeSelector->match() == CSSSelector::Id)
             idScopes.add(scopeSelector->value().impl());
         else
             classScopes.add(scopeSelector->value().impl());
     }
     return true;
@@ skipping 129 matching lines @@
             element->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::StyleSheetChange));
             // The whole subtree is now invalidated, we can skip to the next sibling.
             element = ElementTraversal::nextSkippingChildren(*element);
             continue;
         }
         element = ElementTraversal::next(*element);
     }
 }
 
 }