Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

Issue 1317523002: Changed Pair to be a CSSValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add_const_to_primvalue
Patch Set: Fixed some callsites from bad rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/DeferredLegacyStyleInterpolation.cpp
diff --git a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
index 95d4b2d072b7cd91ab348118f41f38e69545067f..3ea8090830a5a655674bf3bccf351e3f292ade05 100644
--- a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
+++ b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp
@@ -14,7 +14,7 @@
#include "core/css/CSSSVGDocumentValue.h"
#include "core/css/CSSShadowValue.h"
#include "core/css/CSSValueList.h"
-#include "core/css/Pair.h"
+#include "core/css/CSSValuePair.h"
#include "core/css/resolver/StyleResolver.h"
#include "core/css/resolver/StyleResolverState.h"
@@ -54,6 +54,8 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
return interpolationRequiresStyleResolve(toCSSQuadValue(value));
if (value.isValueList())
return interpolationRequiresStyleResolve(toCSSValueList(value));
+ if (value.isValuePair())
+ return interpolationRequiresStyleResolve(toCSSValuePair(value));
if (value.isImageValue())
return interpolationRequiresStyleResolve(toCSSImageValue(value));
if (value.isShadowValue())
@@ -86,11 +88,6 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
|| lengthArray[CSSPrimitiveValue::UnitTypeViewportMax] != 0;
}
- if (Pair* pair = primitiveValue.getPairValue()) {
- return interpolationRequiresStyleResolve(*pair->first())
- || interpolationRequiresStyleResolve(*pair->second());
- }
-
if (primitiveValue.isShape())
return interpolationRequiresStyleResolve(*primitiveValue.getShapeValue());
@@ -131,6 +128,13 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C
return false;
}
+bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValuePair& pair)
+{
+ return interpolationRequiresStyleResolve(*pair.first())
+ || interpolationRequiresStyleResolve(*pair.second());
+}
+
Timothy Loh 2015/08/28 05:51:46 extra blank line
sashab 2015/08/31 00:33:51 Thank you, got rid of one later too (unrelated to
+
bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSBasicShape& shape)
{
// FIXME: Should determine the specific shape, and inspect the members.

Powered by Google App Engine
This is Rietveld 408576698