Add InterestsFetcher which retrieves a user's interests from the server.

chrome/browser/interests/interests_retriever_unittest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <chrome/browser/interests/interests_retriever.h>
+
+#include <base/bind.h>
+#include <base/bind_helpers.h>
+#include <base/memory/ref_counted.h>
+#include <base/message_loop/message_loop.h>
+#include <base/thread_task_runner_handle.h>
+#include <net/base/net_errors.h>
+#include <net/http/http_status_code.h>
+#include <net/url_request/test_url_fetcher_factory.h>
+#include <net/url_request/url_request_status.h>
+#include <net/url_request/url_request_test_util.h>
+#include <testing/gmock/include/gmock/gmock-generated-function-mockers.h>
+#include <testing/gmock/include/gmock/gmock-matchers.h>
+#include <testing/gmock/include/gmock/gmock-more-matchers.h>
+#include <testing/gmock/include/gmock/gmock-spec-builders.h>
+#include <testing/gmock/include/gmock/internal/gmock-generated-internal-utils.h>
+#include <testing/gtest/include/gtest/gtest.h>
+#include <testing/gtest/include/gtest/internal/gtest-internal.h>

[Marc Treib, 2015/09/03 09:04:37]

Is this one necessary?

[tache, 2015/09/03 13:26:29]

Done.

+#include <testing/gtest/include/gtest/internal/gtest-port.h>
+
+using testing::IsEmpty;
+using testing::Not;
+using testing::internal::Notification;

[Marc Treib, 2015/09/03 09:04:37]

This seems unnecessary as well.

[tache, 2015/09/03 13:26:29]

Done.

+
+namespace {
+
+const int kInterestsRetrieverURLFetcherID = 0;
+const std::string kEmptyResponse = "{\n"

[Marc Treib, 2015/09/03 09:04:37]

We don't use global vars of non-trivial types (i.e. anything with a
constructor), so this should be const char[].
(The reason is that the initialization order is not well-defined. I guess it
doesn't matter in a unit test, but still good to be consistent.)

[tache, 2015/09/03 13:26:29]

Done.

+      "\"interest\": []\n"
+    "}\n";
+
+const std::vector<InterestsRetriever::Interest> kExpectedEmptyResponse;
+const std::vector<InterestsRetriever::Interest> kExpectedSuccessfullResponse {

[Marc Treib, 2015/09/03 09:04:37]

"Successful", one "l" :)
Also, again: No uniform initialization yet, and no non-POD globals.

[tache, 2015/09/03 13:26:29]

Done.

+  {"Google", "https://fake.com/fake.png", 0.9},
+  {"Google Chrome", "https://fake.com/fake.png", 0.98}
+};
+
+const std::string kSuccessfulResponse = "{\n"
+    "  \"interest\": [\n"
+    "    {\n"
+    "      \"name\": \"Google\",\n"
+    "      \"imageUrl\": \"https://fake.com/fake.png\",\n"
+    "      \"relevance\": 0.9\n"
+    "    },\n"
+    "    {\n"
+    "      \"name\": \"Google Chrome\",\n"
+    "      \"imageUrl\": \"https://fake.com/fake.png\",\n"
+    "      \"relevance\": 0.98\n"
+    "    }\n"
+    "  ]\n"
+    "}\n";
+
+}  // namespace
+
+class InterestsRetrieverTest : public testing::Test {
+ public:
+  InterestsRetrieverTest()
+      : request_context_(new net::TestURLRequestContextGetter(
+            base::ThreadTaskRunnerHandle::Get())),
+        url_fetcher_factory_(new net::TestURLFetcherFactory()){}
+
+
+  MOCK_METHOD1(OnReceivedInterests,
+               void(std::vector<InterestsRetriever::Interest>));
+
+ protected:
+

[Marc Treib, 2015/09/03 09:04:37]

nit: there's a bunch of extra empty lines in this file

[tache, 2015/09/03 13:26:29]

Done.

+
+  void GetInterests() {
+    requests_.push_back(scoped_ptr<InterestsRetriever>(new InterestsRetriever(
+        request_context_.get(),
+        "secret token",
+        base::Bind(&InterestsRetrieverTest::OnReceivedInterests,
+                   base::Unretained(this)),
+        url_fetcher_factory_.get())));
+  }
+
+  net::TestURLFetcher* GetURLFetcher() {
+    net::TestURLFetcher* url_fetcher = url_fetcher_factory_->GetFetcherByID(
+        kInterestsRetrieverURLFetcherID);
+    EXPECT_TRUE(url_fetcher);
+    return url_fetcher;
+  }
+
+
+  void SendResponse(net::Error error, const std::string& response) {
+    net::TestURLFetcher* url_fetcher = GetURLFetcher();
+    url_fetcher->set_status(net::URLRequestStatus::FromError(error));
+    url_fetcher->set_response_code(net::HTTP_OK);
+    url_fetcher->SetResponseString(response);
+    url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
+  }
+
+
+  void SendValidResponse(const std::string &response) {
+    SendResponse(net::OK, response);
+  }
+
+
+  void SendFailedResponse() {
+    SendResponse(net::ERR_ABORTED, std::string());
+  }
+
+
+  base::MessageLoop message_loop_;
+  scoped_refptr<net::TestURLRequestContextGetter> request_context_;
+  scoped_ptr<net::TestURLFetcherFactory> url_fetcher_factory_;
+  std::vector<scoped_ptr<InterestsRetriever>> requests_;

[Marc Treib, 2015/09/03 09:04:37]

You can't put scoped_ptrs into a vector, because (in C++03) vector's elements
must be copyable.
But I don't think you actually need the vector here, there's never more than one
element, right? Otherwise, use a ScopedVector.

[tache, 2015/09/03 13:26:29]

Switched to using a single scoped_ptr.

+};
+
+TEST_F(InterestsRetrieverTest, EmptyResponse) {
+  GetInterests();
+  EXPECT_CALL(*this, OnReceivedInterests(kExpectedEmptyResponse));
+  SendValidResponse(kEmptyResponse);
+}
+
+TEST_F(InterestsRetrieverTest, SuccessfullResponse) {
+  GetInterests();
+  EXPECT_CALL(*this, OnReceivedInterests(kExpectedSuccessfullResponse));
+  SendValidResponse(kSuccessfulResponse);
+}
+
+TEST_F(InterestsRetrieverTest, FailedResponse) {
+  GetInterests();
+  EXPECT_CALL(*this, OnReceivedInterests(kExpectedEmptyResponse));
+  SendFailedResponse();
+}
+
+TEST_F(InterestsRetrieverTest, DefaultFakeResponse) {
+  GetInterests();
+  EXPECT_CALL(*this, OnReceivedInterests(Not(IsEmpty())));
+  SendValidResponse(InterestsRetriever::FakeResponse());
+}