Support ES 3.0 constants for bufferData's usage argument.

Support ES 3.0 constants for bufferData's usage argument.

BUG=526748
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201503

[Ken Russell (switch to Gerrit), 2015-08-31 18:18:44]

kbr@chromium.org changed reviewers:
+ bajones@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2015-08-31 18:18:44]

PTAL.

This fixes a couple of the errors in the test but there are more to be fixed
(some in the command buffer).

[Zhenyao Mo, 2015-08-31 18:28:34]

LGTM

[Ken Russell (switch to Gerrit), 2015-08-31 18:30:26]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2015-08-31 18:30:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317493003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317493003/1

[Zhenyao Mo, 2015-08-31 18:30:56]

https://codereview.chromium.org/1317493003/diff/1/Source/modules/webgl/WebGL2...
File Source/modules/webgl/WebGL2RenderingContextBase.cpp (right):

https://codereview.chromium.org/1317493003/diff/1/Source/modules/webgl/WebGL2...
Source/modules/webgl/WebGL2RenderingContextBase.cpp:1603: buffer = 0;
By the way, the spec says "If the buffer object named buffer has not been
previously bound, or has been deleted since the last binding, the GL creates a
new state vector, initialized with a zero-sized memory buffer and comprising all
the state and with the same initial values listed in table 2.7.", so it seems
like the deleted object being revised.  In that case, will passing 0 to the GL
driver be correct behavior?

[bajones, 2015-08-31 18:33:33]

On 2015/08/31 18:30:56, Zhenyao Mo wrote:
>
https://codereview.chromium.org/1317493003/diff/1/Source/modules/webgl/WebGL2...
> File Source/modules/webgl/WebGL2RenderingContextBase.cpp (right):
> 
>
https://codereview.chromium.org/1317493003/diff/1/Source/modules/webgl/WebGL2...
> Source/modules/webgl/WebGL2RenderingContextBase.cpp:1603: buffer = 0;
> By the way, the spec says "If the buffer object named buffer has not been
> previously bound, or has been deleted since the last binding, the GL creates a
> new state vector, initialized with a zero-sized memory buffer and comprising
all
> the state and with the same initial values listed in table 2.7.", so it seems
> like the deleted object being revised.  In that case, will passing 0 to the GL
> driver be correct behavior?

LGTM as well, modulo zmo@'s comments.

[Ken Russell (switch to Gerrit), 2015-08-31 18:41:53]

https://codereview.chromium.org/1317493003/diff/1/Source/modules/webgl/WebGL2...
File Source/modules/webgl/WebGL2RenderingContextBase.cpp (right):

https://codereview.chromium.org/1317493003/diff/1/Source/modules/webgl/WebGL2...
Source/modules/webgl/WebGL2RenderingContextBase.cpp:1603: buffer = 0;
On 2015/08/31 18:30:56, Zhenyao Mo wrote:
> By the way, the spec says "If the buffer object named buffer has not been
> previously bound, or has been deleted since the last binding, the GL creates a
> new state vector, initialized with a zero-sized memory buffer and comprising
all
> the state and with the same initial values listed in table 2.7.", so it seems
> like the deleted object being revised.  In that case, will passing 0 to the GL
> driver be correct behavior?

It seems to me there isn't any difference in behavior here between for example
BindBuffer and BindBufferBase; they both have the same spec language around
deleted objects. Since WebGL forbids reviving deleted objects, I think this
behavior is OK (though it should certainly be tested).

[commit-bot: I haz the power, 2015-08-31 20:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 20:13:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2015-08-31 20:44:49]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2015-08-31 20:45:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317493003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317493003/1

[commit-bot: I haz the power, 2015-08-31 21:40:03]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201503