| OLD | NEW |
|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # | 2 # |
| 3 # Copyright 2012 the V8 project authors. All rights reserved. | 3 # Copyright 2012 the V8 project authors. All rights reserved. |
| 4 # Redistribution and use in source and binary forms, with or without | 4 # Redistribution and use in source and binary forms, with or without |
| 5 # modification, are permitted provided that the following conditions are | 5 # modification, are permitted provided that the following conditions are |
| 6 # met: | 6 # met: |
| 7 # | 7 # |
| 8 # * Redistributions of source code must retain the above copyright | 8 # * Redistributions of source code must retain the above copyright |
| 9 # notice, this list of conditions and the following disclaimer. | 9 # notice, this list of conditions and the following disclaimer. |
| 10 # * Redistributions in binary form must reproduce the above | 10 # * Redistributions in binary form must reproduce the above |
| (...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 46 from subprocess import PIPE | 46 from subprocess import PIPE |
| 47 | 47 |
| 48 # Special LINT rules diverging from default and reason. | 48 # Special LINT rules diverging from default and reason. |
| 49 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_". | 49 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_". |
| 50 # build/include_what_you_use: Started giving false positives for variables | 50 # build/include_what_you_use: Started giving false positives for variables |
| 51 # named "string" and "map" assuming that you needed to include STL headers. | 51 # named "string" and "map" assuming that you needed to include STL headers. |
| 52 # TODO(bmeurer): Fix and re-enable readability/check | 52 # TODO(bmeurer): Fix and re-enable readability/check |
| 53 # TODO(mstarzinger): Fix and re-enable readability/namespace | 53 # TODO(mstarzinger): Fix and re-enable readability/namespace |
| 54 | 54 |
| 55 LINT_RULES = """ | 55 LINT_RULES = """ |
| 56 -build/c++11 | |
| 57 -build/header_guard | 56 -build/header_guard |
| 58 +build/include_alpha | 57 +build/include_alpha |
| 59 -build/include_what_you_use | 58 -build/include_what_you_use |
| 60 -build/namespaces | 59 -build/namespaces |
| 61 -readability/check | 60 -readability/check |
| 62 -readability/inheritance | 61 -readability/inheritance |
| 63 -readability/namespace | 62 -readability/namespace |
| 64 -readability/nolint | 63 -readability/nolint |
| 65 +readability/streams | 64 +readability/streams |
| 66 -runtime/references | 65 -runtime/references |
| (...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 457 success = SourceProcessor().Run(workspace) and success | 456 success = SourceProcessor().Run(workspace) and success |
| 458 success = CheckExternalReferenceRegistration(workspace) and success | 457 success = CheckExternalReferenceRegistration(workspace) and success |
| 459 if success: | 458 if success: |
| 460 return 0 | 459 return 0 |
| 461 else: | 460 else: |
| 462 return 1 | 461 return 1 |
| 463 | 462 |
| 464 | 463 |
| 465 if __name__ == '__main__': | 464 if __name__ == '__main__': |
| 466 sys.exit(Main()) | 465 sys.exit(Main()) |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 1317463007:
[presubmit] Enable build/c++11 linter checking. (Closed)
Base URL: https://chromium.googlesource.com/v8/v8.git@master