Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317463002: Introduce composed tree version of nextVisuallyDistinctCandidate() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi, yosin
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of nextVisuallyDistinctCandidate() This patch introduces composed tree version of |nextVisuallyDistinctCandidate()| by templatizing function to share algorithm. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=webkit_unit_tests --gtest_filter=EditingUtilitiesTest.NextVisuallyDistinctCandidate Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201130

Patch Set 1 : 2015-08-25T11:26:15 #

Total comments: 2

Patch Set 2 : 2015-08-25T14:42:38 Follow review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M Source/core/editing/EditingUtilities.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +17 lines, -6 lines 0 comments Download
M Source/core/editing/EditingUtilitiesTest.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-25 04:08:51 UTC) #2
yoichio
https://codereview.chromium.org/1317463002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp File Source/core/editing/EditingUtilitiesTest.cpp (right): https://codereview.chromium.org/1317463002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp#newcode39 Source/core/editing/EditingUtilitiesTest.cpp:39: EXPECT_EQ(Position(two->firstChild(), 1), nextVisuallyDistinctCandidate(Position(one, 2))); 'one' has only 1 child ...
5 years, 4 months ago (2015-08-25 05:22:33 UTC) #3
yosin_UTC9
PTAL https://codereview.chromium.org/1317463002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp File Source/core/editing/EditingUtilitiesTest.cpp (right): https://codereview.chromium.org/1317463002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp#newcode39 Source/core/editing/EditingUtilitiesTest.cpp:39: EXPECT_EQ(Position(two->firstChild(), 1), nextVisuallyDistinctCandidate(Position(one, 2))); On 2015/08/25 05:22:33, yoichio ...
5 years, 4 months ago (2015-08-25 05:44:25 UTC) #4
yoichio
lgtm
5 years, 4 months ago (2015-08-25 07:27:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317463002/20001
5 years, 4 months ago (2015-08-25 07:41:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103683)
5 years, 4 months ago (2015-08-25 08:27:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317463002/20001
5 years, 4 months ago (2015-08-25 09:21:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103749)
5 years, 4 months ago (2015-08-25 10:28:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317463002/20001
5 years, 4 months ago (2015-08-25 10:30:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103789)
5 years, 4 months ago (2015-08-25 11:38:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317463002/20001
5 years, 4 months ago (2015-08-25 12:39:44 UTC) #19
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 13:12:05 UTC) #20
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201130

Powered by Google App Engine
This is Rietveld 408576698