Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317453005: Remove all traces of ChromeShell from src/build. (Closed)

Created:
5 years, 3 months ago by newt (away)
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all traces of ChromeShell from src/build. ChromeShell is about to be deleted. Remove all knowledge of ChromeShell from build. BUG=510220 Committed: https://crrev.com/989d386cbe93ec261df6bd8a87fef5532dea1669 Cr-Commit-Position: refs/heads/master@{#346997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 chunk +0 lines, -6 lines 0 comments Download
M build/android/pylib/instrumentation/setup.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/results/report_results.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 3 months ago (2015-09-02 02:01:20 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-02 17:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317453005/1
5 years, 3 months ago (2015-09-02 18:28:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 19:41:29 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 19:42:05 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/989d386cbe93ec261df6bd8a87fef5532dea1669
Cr-Commit-Position: refs/heads/master@{#346997}

Powered by Google App Engine
This is Rietveld 408576698