Calculate pixel config and stencil fmt pairs once per pixel config.

Calculate pixel config and stencil fmt pairs once per pixel config.

We use a temp FB and stencil buffer to test different stencil formats with
a given pixel config. We then keep a map from pixel config to desired stencil
format.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ff1d547c72b7c70af7bddfba01d4646b2389db7a

[egdaniel, 2015-09-09 21:23:02]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[bsalomon, 2015-09-09 22:02:30]

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1184: int size = 16;
maybe use caps()->minTextureSize()?

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1191: GL_CALL(BindTexture(GR_GL_TEXTURE_2D, colorID));
need to invalidate bound texture tracking

[jvanverth1, 2015-09-10 13:35:03]

Some nits:

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:165: // This value is used as the stencil index when no
stencil configs are support with the
Nit: support -> supported

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.h
File src/gpu/gl/GrGLGpu.h (right):

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.h#ne...
src/gpu/gl/GrGLGpu.h:495: // Mapping of pixel configs to know supported stencil
formats to be used
Nits: know -> known
      adding as -> when adding

[egdaniel, 2015-09-10 13:59:10]

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:165: // This value is used as the stencil index when no
stencil configs are support with the
On 2015/09/10 13:35:03, jvanverth1 wrote:
> Nit: support -> supported

Done.

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1184: int size = 16;
On 2015/09/09 22:02:29, bsalomon wrote:
> maybe use caps()->minTextureSize()?

Done, but still need some default value for cases where the min is 0

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1191: GL_CALL(BindTexture(GR_GL_TEXTURE_2D, colorID));
On 2015/09/09 22:02:29, bsalomon wrote:
> need to invalidate bound texture tracking

Done.

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.h
File src/gpu/gl/GrGLGpu.h (right):

https://codereview.chromium.org/1317443004/diff/20001/src/gpu/gl/GrGLGpu.h#ne...
src/gpu/gl/GrGLGpu.h:495: // Mapping of pixel configs to know supported stencil
formats to be used
On 2015/09/10 13:35:03, jvanverth1 wrote:
> Nits: know -> known
>       adding as -> when adding

Done.

[bsalomon, 2015-09-10 14:30:22]

lgtm w/ suggestion

https://codereview.chromium.org/1317443004/diff/60001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1317443004/diff/60001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1184: int size = this->caps()->minTextureSize() ?
this->caps()->minTextureSize() : 16;
Why don't we just make the min min texture size be 1 so we don't hit this again?

[egdaniel, 2015-09-10 14:48:08]

https://codereview.chromium.org/1317443004/diff/60001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1317443004/diff/60001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1184: int size = this->caps()->minTextureSize() ?
this->caps()->minTextureSize() : 16;
On 2015/09/10 14:30:22, bsalomon wrote:
> Why don't we just make the min min texture size be 1 so we don't hit this
again?

Done.

[egdaniel, 2015-09-10 14:48:12]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-09-10 14:48:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1317443004/#ps70005
(title: "min/max texture nits")

[commit-bot: I haz the power, 2015-09-10 14:48:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317443004/70005
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317443004/70005

[commit-bot: I haz the power, 2015-09-10 14:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-10 14:49:18]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[egdaniel, 2015-09-10 15:32:24]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-09-10 15:32:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1317443004/#ps90001
(title: "Unused variable")

[commit-bot: I haz the power, 2015-09-10 15:32:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317443004/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317443004/90001

[commit-bot: I haz the power, 2015-09-10 15:37:23]

Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/ff1d547c72b7c70af7bddfba01d4646b2389db7a